Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

also use EasyConfig instances cache in process_easyconfig when build_specs is empty dict #4107

Merged
merged 3 commits into from
Oct 26, 2022
Merged

also use EasyConfig instances cache in process_easyconfig when build_specs is empty dict #4107

merged 3 commits into from
Oct 26, 2022

Conversation

boegel
Copy link
Member

@boegel boegel commented Oct 22, 2022 •
edited
Loading

test_easyconfigs_caches added in dbf4697 fails without fix in 5c99f85

@boegel boegel added the bug fix label Oct 22, 2022
@boegel boegel added this to the next release (4.6.3?) milestone Oct 22, 2022
@boegel boegel requested a review from casparvl October 22, 2022 08:33
@boegel boegel removed the request for review from casparvl October 26, 2022 17:26
akesandgren
akesandgren approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Contributor

Going in, thanks @boegel!

@akesandgren akesandgren merged commit adb9086 into easybuilders:develop Oct 26, 2022
@boegel boegel deleted the fix_easyconfigs_cache branch October 26, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akesandgren akesandgren akesandgren approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@boegel @akesandgren