-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release EasyBuild v4.9.3 #4635
Merged
release EasyBuild v4.9.3 #4635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The success message was always printed even when dumping the graph failed resulting in no file being created but a message like: > Error: renderer for .pdf is unavailable > Wrote dependency graph for 1 easyconfigs to graph.pdf
add definition for gmpflf toolchain
ifort is deprecated, so default to ifx
As we also call `obtain_file` for `checksum.json` the progress bar will show one file to many. E.g. > Fetching files: 100% (4/3) Ignore that file for updating the progressbar
This is already done in the easyblock, and needed since the "latest" symlink pointed to the full version in versions < 2024 but to a shorter version (e.g. 2024.2) in 2024 versions.
We calculate MD5 and SHA256 checksums as part of the log output which might take considerable time. Instead of recomputing it in `verify_checksum` we can reuse this value.
fix fetch progress bar showing to many files
Correctly evaluate result for `--dep-graph`
Resolve internal imkl>=2021 version subdir via "latest" symlink
use Intel's oneAPI Fortran compiler by default for version 2024.0.0 and newrer (`oneapi_fortran` toolchain option set to `True`)
CI: Allow using Node 16 actions
fix definition of gmpflf toolchain
Fix typo in message about including an easyblock from a commit
reuse pre-computed checksums
Before checking for strin equality we don't need another check on it. `None != str` for any string `str`
Remove a superflous check in `EasyBlock.run_all_steps`
only call `_sanity_check_step_extensions` if `--skip-extensions` is not set
allow for case where `homepage = None` when generating the docs
Add support for `--software-commit` and an associated template `%(software_commit)s`
add support for `--extra-source-urls` to fetch sources from additional URLs
The dots usually indicate some upcoming process or shortened information. Neither is true at this point: The backup file *has* been saved. Removing the dots makes it also easier to C&P the resulting name as the selection will no longer automatically contain the dots.
Remove trailing dots from backup message.
prepare release notes for EasyBuild v4.9.3 + bump version to 4.9.3
Micket
previously approved these changes
Sep 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This was referenced Sep 14, 2024
fix `test_github_det_commit_status` by using more recent commits
Micket
previously approved these changes
Sep 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Micket
approved these changes
Sep 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.