[formatv2] split off supported section from default section, add preliminary support for a dependencies section #826
Conversation
ghost
assigned 
| Returns None if translation to a dictionary is not possible (e.g. non-equals operator, missing version, ...). | ||
| """ | ||
| version = self.get_version_str() | ||
| if not None in [self.tc_name, version] and self.operator == self.OPERATOR_MAP['==']: |
There was a problem hiding this comment.
what is the idea of the first part of the if? get_version_str can't be None. maybe you just meant if self (see the is_valid and __bool)
There was a problem hiding this comment.
no, I don't need if self
you're right that checking the version (and self.tc_name) is stupid; if no version was specified (e.g. with [goolf]), the version will be set to 0.0.0 anyway...
extended unit tests to cover as_dict() too
…for simple (name,version) deps
…onality in unit tests
|
@stdweird: covered your remarks, had questions w.r.t. a couple of them A unit test for the (basic) |
|
@stdweird: also fixed the |
|
@boegel looks ok to me |
|
@stdweird: maintainer is not enforced for now: (from AUTHOR_REQUIRED = True
MAINTAINER_REQUIRED = FalseMerging in, thanks for the review! |
[formatv2] split off supported section from default section, add preliminary support for a dependencies section
@stdweird: review? it's missing a bit for which I'm counting on you (a parser for the the dependency 'value' string)