Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum Rust version to 1.33 #50

Closed
ebkalderon opened this issue Aug 6, 2019 · 1 comment · Fixed by #51
Closed

Bump minimum Rust version to 1.33 #50

ebkalderon opened this issue Aug 6, 2019 · 1 comment · Fixed by #51
Assignees
Labels

Comments

@ebkalderon
Copy link
Owner

It seems that percent-encoding 2.1.0 is using let bindings in const fn which is causing this CI build to fail on stable Rust 1.31 with the following error:

error: local variables in const fn are unstable
  --> /usr/local/cargo/registry/src/git.luolix.top-1ecc6299db9ec823/percent-encoding-2.1.0/lib.rs:72:13
   |
72 |         let chunk = self.mask[byte as usize / BITS_PER_CHUNK];
   |             ^^^^^

This feature was only stabilized in Rust 1.33 according to this comment. As such, we should probably bump ebkalderon/renderdoc-rs-circleci-dockerfile to a minimum Rust compiler version 1.33.

@ebkalderon
Copy link
Owner Author

I have opened a counterpart issue on the CI Dockerfile repo here: ebkalderon/renderdoc-rs-circleci-dockerfile#1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant