Updated start_frame_capture(), end_frame_capture() #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm sure the docs meant to say that the functions must be paired with each other
ebkalderon
approved these changes
Apr 16, 2022
|
Sorry for the delay! There seemed to be an issue with the Circle CI configuration. I think I'll update it to GitHub Actions this weekend to simplify things. Thanks again for the pull request! 🚀 |
|
No worries, thank you for the useful crate. We have a server that renders but does not present therefore we couldn't take a capture simply from the RenderDoc. So I was relieved when it turned out that there's already a Rust wrapper for RenderDoc API :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sure the docs meant to say that the functions must be paired with each other. Right now it's a bit misleading