Improve type ergonomics and add Error type #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `OnceCell::get_or_try_init()` method will help use construct a common error type to use throughout our library. With `lazy_static`, we would be stuck with a borrowed version of the resulting error instead of an owned value, meaning we cannot `?` or store it anywhere without a lifetime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Errortype to use throughout the library.Changed
PathBuffromget_capture()instead ofString.&Pathfromget_{log,capture}_file_path_template()instead of&str.Into<PathBuf>orInto<String>in some places to avoid extra allocation if possible.pathargument isNonein docs forset_capture_file_comments().lazy_statictoonce_cell.These changes were long overdue, and this crate hasn't seen any love in years. It's time to change that!