Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve type ergonomics and add Error type #82

Merged
merged 7 commits into from
May 1, 2020
Merged

Improve type ergonomics and add Error type #82

merged 7 commits into from
May 1, 2020

Commits on May 1, 2020

  1. Return PathBuf from get_capture() instead of String

    @ebkalderon
    ebkalderon committed May 1, 2020
    Configuration menu
    Copy the full SHA
    3d776d9 View commit details
    Browse the repository at this point in the history

  2. Return &Path from get_{log,capture}_file_path_template()

    @ebkalderon
    ebkalderon committed May 1, 2020
    Configuration menu
    Copy the full SHA
    db3d44c View commit details
    Browse the repository at this point in the history

  3. Accept Into<PathBuf> to avoid allocation if possible

    @ebkalderon
    ebkalderon committed May 1, 2020
    Configuration menu
    Copy the full SHA
    f8d6157 View commit details
    Browse the repository at this point in the history

  4. Document if path arg is None in set_capture_file_comments()

    @ebkalderon
    ebkalderon committed May 1, 2020
    Configuration menu
    Copy the full SHA
    c34dd9c View commit details
    Browse the repository at this point in the history

  5. Switch from lazy_static to once_cell 

    The `OnceCell::get_or_try_init()` method will help use construct a
common error type to use throughout our library. With `lazy_static`, we
would be stuck with a borrowed version of the resulting error instead of
an owned value, meaning we cannot `?` or store it anywhere without a
lifetime.
    @ebkalderon
    ebkalderon committed May 1, 2020
    Configuration menu
    Copy the full SHA
    be0738d View commit details
    Browse the repository at this point in the history

  6. Add common Error type to use throughout the library

    @ebkalderon
    ebkalderon committed May 1, 2020
    Configuration menu
    Copy the full SHA
    ef518b8 View commit details
    Browse the repository at this point in the history

  7. Accept Into<String> to avoid allocation if possible

    @ebkalderon
    ebkalderon committed May 1, 2020
    Configuration menu
    Copy the full SHA
    f663223 View commit details
    Browse the repository at this point in the history