Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

[Compact Profile 2] - Smarthome UI bundle depends on Full JRE packages #5326

Closed
svilenvul opened this issue Mar 30, 2018 · 2 comments
Closed

Comments

@svilenvul
Copy link
Contributor

Looking at the report generated by openhab/static-code-analysis#283, I see that several packages in org.eclipse.smarthome.ui bundle depend on packages in the Full JRE :

  • org.eclipse.smarthome.ui.chart depends on java.awt.image
  • org.eclipse.smarthome.ui.internal.chart depends on java.awt.image
  • org.eclipse.smarthome.ui.internal.chart depends on javax.imageio
  • org.eclipse.smarthome.ui.internal.chart depends on javax.imageio.stream
  • org.eclipse.smarthome.ui.internal.chart.defaultchartprovider depends on java.awt
  • org.eclipse.smarthome.ui.internal.chart.defaultchartprovider depends on java.awt.image

This is a violation of C.1 in the ESH coding guidelines https://www.eclipse.org/smarthome/documentation/development/guidelines.html#c-language-levels-and-libraries.

@kaikreuzer
Copy link
Contributor

It might make sense to split the chart support to a separate bundle and mark it with an exception (only working with full JRE).
But then again, there wouldn't be much left in smarthome.ui but the ItemUIRegistry/Provider, which itself depends on Xtext/EMF/etc. and thus isn't really applicable for constraint devices either - this should change in the context of #5337, so maybe it makes sense to wait for these steps.

@svilenvul tl;dr: I would suggest to add an exclusion for this check for this bundle.

@svilenvul
Copy link
Contributor Author

Great, I will add it as exception.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants