Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the prefix of the configuration parameters from Manager to Controller #705

Closed
ygalblum opened this issue Jan 16, 2024 · 0 comments · Fixed by #704
Closed

Change the prefix of the configuration parameters from Manager to Controller #705

ygalblum opened this issue Jan 16, 2024 · 0 comments · Fixed by #704
Assignees
@ygalblum
Labels
breaking Requested changes will break existing usages bug Something isn't working
Milestone
v0.7

Comments

@ygalblum
Copy link
Contributor

Required changes

Since the bluechi manager was renamed to controller the configuration parameters should have the appropriate prefix.

Controller Configuration

ManagerPort -> ControllerPort

Agent Configuration

ManagerHost -> ControllerHost
ManagerPort -> ControllerPort
ManagerAddress -> ControllerAddress

This change will break current usage.
@ygalblum ygalblum added bug Something isn't working breaking Requested changes will break existing usages labels Jan 16, 2024
@ygalblum ygalblum mentioned this issue Jan 16, 2024
Merged
@ygalblum ygalblum self-assigned this Jan 16, 2024
@engelmi engelmi added this to the v0.7 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ygalblum ygalblum

Labels
breaking Requested changes will break existing usages bug Something isn't working
Projects
None yet
Milestone
v0.7
Development

Successfully merging a pull request may close this issue.

Configuration parameters prefix - replace Manager with Controller ygalblum/bluechi
2 participants
@ygalblum @engelmi