Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover function user_bus_open from libbluechi/bus/bus.c by tests #799

Closed
mwperina opened this issue Mar 7, 2024 · 3 comments · Fixed by #899
Closed

Cover function user_bus_open from libbluechi/bus/bus.c by tests #799

mwperina opened this issue Mar 7, 2024 · 3 comments · Fixed by #899
Assignees
Labels
jira Issues that are synced to Jira testing This issue adds or improves the testing
Milestone

Comments

@mwperina
Copy link
Member

mwperina commented Mar 7, 2024

Cover function user_bus_open by unit or integration tests

@mwperina mwperina added the enhancement New feature or request label Mar 7, 2024
@mwperina mwperina added this to the v0.8 milestone Mar 7, 2024
@mwperina
Copy link
Member Author

mwperina commented Mar 7, 2024

Could it be covered this along with -u/--user test for bluechi #787 ?

@engelmi
Copy link
Member

engelmi commented Mar 7, 2024

Could it be covered this along with -u/--user test for bluechi #787 ?

For bluechi-agent yes. For bluechi-controller, however, it is set at compile-time. But for the test of using the user bus, this should be fine. For root the user bus isn't set as far as I remember, so this might be difficult to test.

@mwperina
Copy link
Member Author

mwperina commented Mar 7, 2024

I think testing with bluechi-agent is enough, user bus should not be used in production anyway

@mkemel mkemel self-assigned this Mar 7, 2024
@mkemel mkemel added the jira Issues that are synced to Jira label Mar 7, 2024
@engelmi engelmi modified the milestones: v0.8, v0.9 Apr 24, 2024
@engelmi engelmi added testing This issue adds or improves the testing and removed enhancement New feature or request labels Apr 24, 2024
mkemel added a commit to mkemel/bluechi that referenced this issue Apr 30, 2024
Resolves: eclipse-bluechi#799
Signed-off-by: Mark Kemel <mkemel@redhat.com>
mkemel added a commit to mkemel/bluechi that referenced this issue Apr 30, 2024
Resolves: eclipse-bluechi#799
Signed-off-by: Mark Kemel <mkemel@redhat.com>
mkemel added a commit to mkemel/bluechi that referenced this issue Apr 30, 2024
Resolves: eclipse-bluechi#799
Signed-off-by: Mark Kemel <mkemel@redhat.com>
mkemel added a commit to mkemel/bluechi that referenced this issue May 1, 2024
Resolves: eclipse-bluechi#799
Signed-off-by: Mark Kemel <mkemel@redhat.com>
mkemel added a commit to mkemel/bluechi that referenced this issue May 2, 2024
Resolves: eclipse-bluechi#799
Signed-off-by: Mark Kemel <mkemel@redhat.com>
mkemel added a commit to mkemel/bluechi that referenced this issue May 5, 2024
Resolves: eclipse-bluechi#799
Signed-off-by: Mark Kemel <mkemel@redhat.com>
mkemel added a commit to mkemel/bluechi that referenced this issue May 5, 2024
Resolves: eclipse-bluechi#799
Signed-off-by: Mark Kemel <mkemel@redhat.com>
mkemel added a commit to mkemel/bluechi that referenced this issue May 5, 2024
Resolves: eclipse-bluechi#799
Signed-off-by: Mark Kemel <mkemel@redhat.com>
mkemel added a commit to mkemel/bluechi that referenced this issue May 5, 2024
Resolves: eclipse-bluechi#799
Signed-off-by: Mark Kemel <mkemel@redhat.com>
mkemel added a commit to mkemel/bluechi that referenced this issue May 6, 2024
Resolves: eclipse-bluechi#799
Signed-off-by: Mark Kemel <mkemel@redhat.com>
mkemel added a commit that referenced this issue May 6, 2024
Resolves: #799
Signed-off-by: Mark Kemel <mkemel@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira Issues that are synced to Jira testing This issue adds or improves the testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants