Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved logging for loading configuration files #234

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

engelmi
Copy link
Member

@engelmi engelmi commented Mar 31, 2023

This PR

  • introduces a cfg_dump to log the final configuration being used (on debug level)
  • adds more concise logging when loading the configuration
  • removes any return when failing to load a configuration file (except for OOM errors) as a following configuration might be valid as well

src/libhirte/common/cfg.c Show resolved Hide resolved
src/libhirte/common/cfg.c Show resolved Hide resolved
src/libhirte/common/cfg.c Show resolved Hide resolved
src/libhirte/common/cfg.c Show resolved Hide resolved
src/libhirte/common/cfg.c Show resolved Hide resolved
src/libhirte/common/cfg.c Show resolved Hide resolved
src/libhirte/common/cfg.c Show resolved Hide resolved
src/libhirte/common/cfg.h Show resolved Hide resolved
@engelmi engelmi force-pushed the improve-logging-for-config branch 2 times, most recently from 4b40b55 to c85a6b7 Compare March 31, 2023 09:53
src/libhirte/common/cfg.c Outdated Show resolved Hide resolved
Signed-off-by: Michael Engel <mengel@redhat.com>
@engelmi engelmi merged commit 7d7d984 into main Mar 31, 2023
@engelmi engelmi deleted the improve-logging-for-config branch March 31, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants