added dnf upgrade when building the integration-test-base image #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Engel <mengel@redhat.com>
engelmi
requested review from
alexlarsson,
mkemel,
rhatdan and
sdunnagan
as code owners
This was referenced May 31, 2023
Merged
|
LGTM |
dougsland
approved these changes
May 31, 2023
dougsland
approved these changes
May 31, 2023
dougsland
approved these changes
May 31, 2023
dougsland
approved these changes
May 31, 2023
mwperina
reviewed
Jun 1, 2023
| @@ -2,6 +2,8 @@ FROM quay.io/centos/centos:stream9 | |||
|
|
|||
| RUN dnf install -y dnf-plugin-config-manager | |||
|
|
|||
| RUN dnf upgrade --refresh -y | |||
There was a problem hiding this comment.
Hmm, we are already getting the latest CS9 container as a base here, so does it mean that the container might not be synced with the actual content of CS9 repos? Meaning that for example container is recreated only once per day while repos are updated regularly during the day?
There was a problem hiding this comment.
Since we don't have any control over the base image we cannot guaranty what's in it and what will be there the following day. As a result using dnf upgrade is the right way to go.
I would argue that this line could have been merged with the next one, making it a single layer. But, since it's a test image, it's not that important.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
dnf upgradeprevious to installing the necessary packages. This way we avoid conflicts in packages, e.g.12:51:09 err: Problem: conflicting requests 12:51:09 err: - nothing provides selinux-policy >= 38.1.14-1.el9 needed by hirte-selinux-0.3.0-1.el9.x86_64 from hirte-rpmsNote: the updated
integration-test-baseimage was already pushed manually (otherwise the integration test in this PR would fail as well).