fixed get_address unit test #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unit test of get_address used redhat.com as a case to resolve a domain name. This, however, requires an internet connection to work. Changed it to use localhost instead so the unit test doesn't have a network dependency. Signed-off-by: Michael Engel <mengel@redhat.com>
engelmi
requested review from
alexlarsson,
mkemel,
rhatdan and
sdunnagan
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests on COPR are failing since #340 has been merged (see this build, for example).
The unit test of get_address used
redhat.comas a test case to resolve a domain name. This, however, requires an internet connection to work. This PR changed it to uselocalhostinstead so the unit test doesn't have a network dependency.