fix segfault on disconnected anonymous node #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an anonymous node disconnects, it gets removed from the manager. This already unsets the agent bus. And after emitting state changing signals, the bus and slots where unset again, causing a segfault. To prevent this, call node_unset_agent_bus on disconnect only for named nodes as this is already done when removing the anonymous node from the manager. Signed-off-by: Michael Engel <mengel@redhat.com>
engelmi
requested review from
alexlarsson,
mkemel,
rhatdan and
sdunnagan
as code owners
|
@dougsland Could you test if this change fixes the issue? |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #426
When an anonymous node disconnects, it gets removed from the manager. This already unsets the agent bus. And after emitting state changing signals, the bus and slots where unset again, causing a segfault. To prevent this, call node_unset_agent_bus on disconnect only for named nodes as this is already done when removing the anonymous node from the manager.