added integration test for wildcard subscriptions #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engelmi
requested review from
alexlarsson,
mkemel,
rhatdan and
sdunnagan
as code owners
engelmi
force-pushed
the
add-integration-test-monitor-unit-changes
branch
2 times, most recently
from
bb5b3df
to
3d9125a
Compare
Fixes: #414 Adds an integration test that verifies that the all signals when starting and stopping a unit will be received by a wildcard monitor subscription with a setup of multiple nodes. Signed-off-by: Michael Engel <mengel@redhat.com>
engelmi
force-pushed
the
add-integration-test-monitor-unit-changes
branch
from
3d9125a
to
caa4091
Compare
dougsland
approved these changes
Aug 30, 2023
Do you know which part of the test takes long? If it is the setup, then its probably best to implement a scoped timeout that can be used via a with timeout(30, timeout_handler):
long_running_statement()Then we can remove the overall timeout and only apply it where it is really needed. This would be a common functionality. I'll have a look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #414
Adds an integration test that verifies that the all signals when starting and stopping a unit will be received by a wildcard monitor subscription with a setup of multiple nodes.