Add option to enable code coverage support when building RPMs #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtiomDivak
requested review from
alexlarsson,
engelmi,
mkemel,
rhatdan and
sdunnagan
as code owners
ArtiomDivak
force-pushed
the
issue-397
branch
2 times, most recently
from
155793b
to
71f7d1e
Compare
|
LGTM but I am wondering who will enable such feature in rpm? |
|
@ArtiomDivak in the description I see [WIP], is it still WIP? Looks good |
engelmi
reviewed
Sep 1, 2023
ArtiomDivak
force-pushed
the
issue-397
branch
3 times, most recently
from
e568111
to
be40725
Compare
mwperina
requested changes
Sep 4, 2023
ArtiomDivak
force-pushed
the
issue-397
branch
from
be40725
to
7722185
Compare
mwperina
requested changes
Sep 11, 2023
ArtiomDivak
force-pushed
the
issue-397
branch
2 times, most recently
from
de5d4db
to
88131e2
Compare
mwperina
requested changes
Sep 11, 2023
There was a problem hiding this comment.
Please also use more descriptive commit message, for example:
Add option to enable code coverage support when building RPMs
To enable building RPMs with code coverage support `-Dwith_coverage=1`
parameter can be passed to rpmbuild. Code coverage support is turned
off by default when building RPMs.
Related: https://github.com/containers/bluechi/issues/397
Signed-off-by: Artiom Divak <adivak@redhat.com>
6a635c4
to
4e242ec
Compare
mwperina
reviewed
Sep 13, 2023
ArtiomDivak
force-pushed
the
issue-397
branch
2 times, most recently
from
a63201e
to
68fd4bd
Compare
ArtiomDivak
force-pushed
the
issue-397
branch
from
68fd4bd
to
953872d
Compare
mwperina
requested changes
Sep 14, 2023
test.txt
Outdated
There was a problem hiding this comment.
This file should not be part of the commit
ArtiomDivak
force-pushed
the
issue-397
branch
from
953872d
to
a403a77
Compare
mwperina
reviewed
Sep 14, 2023
mwperina
reviewed
Sep 14, 2023
ArtiomDivak
force-pushed
the
issue-397
branch
from
a403a77
to
ba51bfe
Compare
mwperina
requested changes
Sep 14, 2023
|
Please fetch the latest changes from |
ArtiomDivak
force-pushed
the
issue-397
branch
4 times, most recently
from
d23c439
to
e606eb7
Compare
To enable building RPMs with code coverage support `-Dwith_coverage=1` parameter can be passed to rpmbuild. Code coverage support is turned off by default when building RPMs. Related: eclipse-bluechi#397 Signed-off-by: Artiom Divak <adivak@redhat.com>
mwperina
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable building RPMs with code coverage support
-Dwith_coverage=1parameter can be passed to rpmbuild. Code coverage support is turned
off by default when building RPMs.
Related: #397
Signed-off-by: Artiom Divak adivak@redhat.com