bluechictl: add flags to enable and disable commands #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkemel
force-pushed
the
enable-flags
branch
3 times, most recently
from
56c21da
to
0779274
Compare
Adding the following flags: enable: `--force`, `--runtime` and `--no-reload` disable: `--runtime` and `--no-reload` Removed the short `-f` option for `--filter` option, since `-f` is more common for --force than for filter Signed-off-by: Mark Kemel <mkemel@redhat.com>
The patch looks good to me so the merge is completely valid (I also did some tests) but was faster than me. :) |
|
@dougsland good point, thanks for your remark. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the following flags:
enable:
--force,--runtimeand--no-reloaddisable:
--runtimeand--no-reloadRemoved the short
-foption for--filteroption, since-fis more common for--forcethan for--filterResolves #323