-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lsof for integration-test-base #696
Conversation
lsof needed to check if port connected inside controller/agent container. Signed-off-by: Artiom Divak <adivak@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why exactly is this necessary? Shouldn't it be sufficient/better to use the current tooling like bluechictl to check if the agent is connected?
Note: This also requires rebuilding the image and pushing to quay.io.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow up of #696 (review):
This is how it was done previously:
https://github.com/eclipse-bluechi/bluechi/blob/main/tests/tests/tier0/monitor-node-reconnect/python/is_node_connected.py
We should check that a different port passed though command line option has been accepted by controller and the controller started to listen on a different port |
And changing the port for both, controller and agent, observing the disconnect and (after changing the agent) the reconnect of the agent is "too high level", I guess, since we are not really verify the new port. |
My test thoughts: #680 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lsof needed to check if port connected inside
controller/agent container.