-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bluechictl: status command to show nodes list #700
Conversation
83dd55b
to
a8b39ca
Compare
Fixing integration tests and docs in progress |
I think if you update the branch, the two failing integration tests will pass - these tests were recently added and a bit flaky. It has been improved in #699 |
a8b39ca
to
5a9f5f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'd like to have the -w
option also for the unit, e.g.
bluechictl status laptop cow.service
But that can be done in a separate PR. I'll create an issue for it.
@engelmi thanks, I was exactly thinking about it while updating the docs |
6a5fa8f
to
537f36e
Compare
Nice, thanks for updating the docs! |
In this commit we remove the `bluechictl monitor node-connection` functionality and move it to `bluechictl status`, slightly expanding it. `bluechictl status` will print the list of nodes with their status and when it was last seen. `bluechictl status node` will print the same for for the node `node` Also adding `-w/--watch` flag to `bluechictl status` command, allowing to continuously monitor the node/nodes status (like the original `bluechictl monitor node-connection` Signed-off-by: Mark Kemel <mkemel@redhat.com>
Signed-off-by: Mark Kemel <mkemel@redhat.com>
537f36e
to
28a4e91
Compare
/packit test --labels valgrind |
Removing the
bluechictl monitor node-connection
functionality and move it tobluechictl status
, slightly expanding it.bluechictl status
will print the list of nodes with their status and when it was last seen.bluechictl status node
will print the same for for the nodenode
Also adding
-w/--watch
flag tobluechictl status
command, allowing to continuously monitor the node/nodes status (like the originalbluechictl monitor node-connection
)bluechictl status node unit
retains the original functionalityResolves #281