Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluechictl: status command to show nodes list #700

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

mkemel
Copy link
Member

@mkemel mkemel commented Jan 15, 2024

Removing the bluechictl monitor node-connection functionality and move it to bluechictl status, slightly expanding it.

bluechictl status will print the list of nodes with their status and when it was last seen.

$ sudo bluechictl status
NODE                          | STATE     | LAST SEEN                   
=========================================================================
laptop                        | online    | now                                            
rpi4                          | offline   | never                       

bluechictl status node will print the same for for the node node

$ sudo bluechictl status laptop
NODE                          | STATE     | LAST SEEN                   
=========================================================================
laptop                        | online    | now                         

Also adding -w/--watch flag to bluechictl status command, allowing to continuously monitor the node/nodes status (like the original bluechictl monitor node-connection)

bluechictl status node unit retains the original functionality

Resolves #281

@mkemel
Copy link
Member Author

mkemel commented Jan 15, 2024

Fixing integration tests and docs in progress

@engelmi
Copy link
Member

engelmi commented Jan 15, 2024

Fixing integration tests and docs in progress

I think if you update the branch, the two failing integration tests will pass - these tests were recently added and a bit flaky. It has been improved in #699

Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'd like to have the -w option also for the unit, e.g.

bluechictl status laptop cow.service

But that can be done in a separate PR. I'll create an issue for it.

@mkemel
Copy link
Member Author

mkemel commented Jan 16, 2024

@engelmi thanks, I was exactly thinking about it while updating the docs
Pushed doc updates (with a small fix for the previous PR), in a new commit - please take a look. The commit is independent, no need to squash on PR merge

@engelmi
Copy link
Member

engelmi commented Jan 16, 2024

@engelmi thanks, I was exactly thinking about it while updating the docs Pushed doc updates (with a small fix for the previous PR), in a new commit - please take a look. The commit is independent, no need to squash on PR merge

Nice, thanks for updating the docs!
LGTM. Could you update the branch? @mkemel Then it can be merged :)

In this commit we remove the `bluechictl monitor node-connection`
functionality and move it to `bluechictl status`, slightly expanding
it.

`bluechictl status` will print the list of nodes with their status
and when it was last seen.

`bluechictl status node` will print the same for for the node `node`

Also adding `-w/--watch` flag to `bluechictl status` command,
allowing to continuously monitor the node/nodes status (like the
original `bluechictl monitor node-connection`

Signed-off-by: Mark Kemel <mkemel@redhat.com>
Signed-off-by: Mark Kemel <mkemel@redhat.com>
@mkemel
Copy link
Member Author

mkemel commented Jan 16, 2024

/packit test --labels valgrind

@engelmi engelmi merged commit 7ebc2b3 into eclipse-bluechi:main Jan 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: hirtectl connection-status [NODE-NAME]
2 participants