Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration parameters prefix - replace Manager with Controller #704

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Configuration parameters prefix - replace Manager with Controller #704

merged 2 commits into from
Jan 16, 2024

Conversation

ygalblum
Copy link
Contributor

@ygalblum ygalblum commented Jan 16, 2024 •
edited
Loading

Resolves: #705

@ygalblum
Configuration parameters prefix - replace Manager with Controller
be3caec 
Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
mwperina
mwperina approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this is merged we need a follow-up patch which will rename manager to controller in all remaining text.

mkemel
mkemel approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@mkemel mkemel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

engelmi
engelmi reviewed Jan 16, 2024
View reviewed changes
Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change in the link to the man pages, otherwise LGTM

doc/docs/getting_started/multi_node.md Outdated Show resolved Hide resolved
@ygalblum @engelmi
Fix reference to other MD file
52c200f 
Co-authored-by: Michael Engel <engel.michael@hotmail.de>
Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
@engelmi engelmi merged commit 00089a6 into eclipse-bluechi:main Jan 16, 2024
18 checks passed
@ygalblum ygalblum deleted the rename-agent-param-prefix branch January 16, 2024 10:53
@mwperina mwperina mentioned this pull request Jan 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelmi engelmi engelmi left review comments

@mkemel mkemel mkemel approved these changes

@mwperina mwperina mwperina approved these changes

@alexlarsson alexlarsson Awaiting requested review from alexlarsson alexlarsson is a code owner

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the prefix of the configuration parameters from Manager to Controller
4 participants
@ygalblum @mwperina @engelmi @mkemel