Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy gcno files into dedictated directories #709

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

engelmi
Copy link
Member

@engelmi engelmi commented Jan 17, 2024

By copying the gcno files into the dedicated directories naming collisions are avoided which, in turn, results in missing coverage for those overwritten files. This also applies to moving the .gcda files into those dedicated project directories, e.g. libbluechi, during the collection of these files.

Note:
The name collision is most visible in the main.c as every subproject (manager, agent, etc.) is having one. In previous integration test runs, the report contains only one main.c (e.g. for the agent) and the others where "overwritten". The proxy project, which solely consists of a main.c, wasn't even shown. This PR fixes this.

Example, before:
image

Example, after:
image

By copying the gcno files into the dedicated directories
naming collisions are avoided which, in turn, results in
missing coverage for those overwritten files.
This also applies to moving the .gcda files into those
dedicated project directories, e.g. libbluechi, during
the collection of these files.

Signed-off-by: Michael Engel <mengel@redhat.com>
@engelmi
Copy link
Member Author

engelmi commented Jan 17, 2024

/cc @ArtiomDivak

Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelmi engelmi merged commit 13f022d into eclipse-bluechi:main Jan 17, 2024
18 checks passed
@engelmi engelmi deleted the fix-coverage-collection branch February 28, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants