Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Manager -> Controller #712

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Rename Manager -> Controller #712

merged 2 commits into from
Jan 18, 2024

Conversation

mkemel
Copy link
Member

@mkemel mkemel commented Jan 18, 2024 •
edited
Loading

Full and deep rename of the Manager to Controller, including file names, variable names, comments, etc.

Resolves #707

@mkemel mkemel marked this pull request as ready for review January 18, 2024 13:22
mwperina
mwperina reviewed Jan 18, 2024
View reviewed changes
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally it looks great, just a few small suggestions

config/agent/agent.conf Outdated Show resolved Hide resolved
config/controller/controller.conf Outdated Show resolved Hide resolved
doc/docs/getting_started/multi_node.md Outdated Show resolved Hide resolved
doc/docs/getting_started/securing_multi_node.md Outdated Show resolved Hide resolved
doc/docs/getting_started/single_node.md Outdated Show resolved Hide resolved
doc/docs/getting_started/single_node.md Outdated Show resolved Hide resolved
doc/man/bluechi-controller.conf.5.md Outdated Show resolved Hide resolved
doc/man/bluechi-controller.conf.5.md Outdated Show resolved Hide resolved
@mkemel
Rename Manager -> Controller
af5a49b 
Signed-off-by: Mark Kemel <mkemel@redhat.com>
@mkemel
regenerate bindings
7ee6de0 
Signed-off-by: Mark Kemel <mkemel@redhat.com>
engelmi
engelmi approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(The failing apispec is due to the generator creating the functions etc. unordered. Has to be fixed in the future. For now, we can ignore that failure.)

@mkemel mkemel merged commit f2cd879 into eclipse-bluechi:main Jan 18, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwperina mwperina mwperina left review comments

@engelmi engelmi engelmi approved these changes

@alexlarsson alexlarsson Awaiting requested review from alexlarsson alexlarsson is a code owner

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

@ygalblum ygalblum Awaiting requested review from ygalblum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename occurrences of Manager to Controller
3 participants
@mkemel @mwperina @engelmi