Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordered output for python bindings generator #724

Merged

Conversation

engelmi
Copy link
Member

@engelmi engelmi commented Jan 30, 2024

Fixes: #716

It orders the interfaces as well as its methods, signals and properties by name so that the generated output is deterministic.

@engelmi
Copy link
Member Author

engelmi commented Jan 30, 2024

/packit rebuild-failed

Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwperina
Copy link
Member

/packit retest-failed

1 similar comment
@mwperina
Copy link
Member

/packit retest-failed

@engelmi engelmi force-pushed the binding-generator-ordered-output branch from 8d46cf2 to e4683a1 Compare January 30, 2024 13:07
@engelmi
Copy link
Member Author

engelmi commented Jan 30, 2024

/packit retest-failed

1 similar comment
@engelmi
Copy link
Member Author

engelmi commented Jan 31, 2024

/packit retest-failed

Fixes: eclipse-bluechi#716

It orders the interfaces as well as its methods, signals and
properties by name so that the generated output is deterministic.

Signed-off-by: Michael Engel <mengel@redhat.com>
@engelmi engelmi force-pushed the binding-generator-ordered-output branch from e4683a1 to 8a273fb Compare January 31, 2024 13:37
@engelmi engelmi merged commit c0284d7 into eclipse-bluechi:main Jan 31, 2024
18 checks passed
@engelmi engelmi deleted the binding-generator-ordered-output branch February 28, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tyed python bindings generator: unordered output
2 participants