Split up parse config function #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engelmi
requested review from
alexlarsson,
mkemel and
rhatdan
as code owners
engelmi
force-pushed
the
split-up-parse-config-function
branch
2 times, most recently
from
80c6499
to
30ecf62
Compare
mwperina
approved these changes
Feb 14, 2024
Relates to: eclipse-bluechi#678 The parse functions agent_parse_config and controller_parse_config initialize the config, set default values there, load configuration from all sources and sets the loaded values to the agent/controller fields. This is a bit much, therefore, split setting the values out to a dedicated function. In addition to a smaller, easier to read function it also simplifies writing unit tests. Signed-off-by: Michael Engel <mengel@redhat.com>
Relates to: eclipse-bluechi#678 Added unit tests for the previously split out function to set the values from the loaded configuration to the agent/controller fields. Signed-off-by: Michael Engel <mengel@redhat.com>
Two leaks are fixed: - agent_unref did not free the peer_socket_options - unit_infos was allocated twice Signed-off-by: Michael Engel <mengel@redhat.com>
Signed-off-by: Michael Engel <mengel@redhat.com>
engelmi
force-pushed
the
split-up-parse-config-function
branch
from
df15764
to
71662b0
Compare
|
There is still an error in the coverage collection causing it to drop - we are on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #678
The parse functions agent_parse_config and controller_parse_config initialize the config, set default values there, load configuration from all sources and sets the loaded values to the agent/controller fields. This is a bit much, therefore, split setting the values out to a dedicated function. In addition to a smaller, easier to read function it also simplifies writing unit tests - which are also added in this PR.
It also fixes two memory leaks: