Add support for GetUnitFileState API #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwperina
requested review from
alexlarsson,
engelmi,
mkemel and
rhatdan
as code owners
mwperina
force-pushed
the
get-unit-file-status
branch
from
2fdd3f8
to
9ef9fce
Compare
|
/packit test-failed |
|
/packit retest-failed |
mwperina
force-pushed
the
get-unit-file-status
branch
2 times, most recently
from
6e25ef1
to
0bca2e4
Compare
|
/packit retest-failed |
ArtiomDivak
reviewed
Sep 30, 2024
mkemel
reviewed
Oct 1, 2024
|
Looks great! Just a small improvement suggestion from my side |
- Adds support for GetUnitFileState API on controller and node - Adds is-enabled command to bluechictl - Adds integration test Fixes: eclipse-bluechi#934 Signed-off-by: Martin Perina <mperina@redhat.com>
mwperina
force-pushed
the
get-unit-file-status
branch
from
0bca2e4
to
6c8b545
Compare
|
/packit retest-failed |
2 similar comments
|
/packit retest-failed |
|
/packit retest-failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #934
Signed-off-by: Martin Perina mperina@redhat.com