Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some branch related actions are enabled even if the repository does not support branching #65

Open
mPorhel opened this issue Aug 20, 2024 · 1 comment
Open

Some branch related actions are enabled even if the repository does not support branching #65

mPorhel opened this issue Aug 20, 2024 · 1 comment

Comments

@mPorhel
Copy link
Contributor

mPorhel commented Aug 20, 2024

Actions "Checkout", "Checkout As..." and "Create Branch..." should be disabled if branching is not supported for the selected repository
mPorhel pushed a commit to mPorhel/cdo that referenced this issue Aug 20, 2024
@lfasani @mPorhel
Disable some CDO menus when branching is not supported eclipse-cdo#65
c70f6d2 
This commit disable the action "Checkout", "Checkout As..." and "Create
Branch..." if the branching is not supported.

Change-Id: Ic342305e252001c3a7a75d2ae82c0d29bd2bbe6f
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
mPorhel pushed a commit to mPorhel/cdo that referenced this issue Aug 20, 2024
@lfasani @mPorhel
Disable some CDO menus when branching is not supported eclipse-cdo#65
50d7274 
This commit disable the action "Checkout", "Checkout As..." and "Create
Branch..." if the branching is not supported.

Change-Id: Ic342305e252001c3a7a75d2ae82c0d29bd2bbe6f
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
@estepper
Copy link
Contributor

estepper commented Dec 8, 2024

Hi Maxime,

The actions "Checkout" and "Checkout As..." must be enabled also without branching. How else would you create a checkout that you can work with? We could discuss whether the wizard page with the branch selection is unwanted in that case. But technically the MAIN branch does always exist.

The "Create Branch..." action should be disabled for repos without branching. But I just tested it, and it is disabled (actually not even visible).

In the end I see no need for action here. Or am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@estepper @mPorhel