Operator sdk 0.15.2 #515
Operator sdk 0.15.2 #515
Conversation
tomgeorge
requested review from
davidfestal,
nickboldt and
tolusha
as code owners
|
@tomgeorge
|
|
/retest |
|
|
Removed |
|
/retest |
olm/docker-run.sh
Outdated
| @@ -43,9 +43,9 @@ check() { | |||
| build() { | |||
| printf "%bBuilding image %b${IMAGE_NAME}${NC}..." "${BOLD}" "${BLUE}" | |||
| if docker build --build-arg OPERATOR_SDK_VERSION=${OPERATOR_SDK_VERSION} -t ${IMAGE_NAME} > docker-build-log 2>&1 -<<EOF | |||
| FROM evns/yq | |||
| FROM golang:1.14-alpine | |||
There was a problem hiding this comment.
Should we use golang:1.13-alphine since we switched from 1.12 to 1.13 version ?
| @@ -1,14 +1,17 @@ | |||
| FROM quay.io/operator-framework/upstream-registry-builder as builder | |||
| COPY deploy manifests/eclipse-che-preview-openshift | |||
|
|
|||
| COPY deploy manifests/eclipse-che-preview-kubernetes | |||
There was a problem hiding this comment.
Typo?
It should be deploy manifests/eclipse-che-preview-openshift
| COPY --from=builder /build/bin/configmap-server /bin/configmap-server | ||
| COPY --from=builder /build/bundles.db /bundles.db | ||
| COPY --from=builder /build/bin/registry-server /registry-server | ||
| COPY --from=builder /bin/initializer /initializer |
There was a problem hiding this comment.
To be honest I don't understand why /build isn't necessary anymore. Could you explain pls?
There was a problem hiding this comment.
During my testing, running quay.io/operator-framework/upstream-registry-builder had moved it's artifacts out of /build
There was a problem hiding this comment.
We could tag to a specific image
There was a problem hiding this comment.
Yes, this image will be updated and pinned #522 in the frame of the issue: che#18105
There was a problem hiding this comment.
that is the upstream-opm-builder image, not the upstream-registry-builder. If upstream-registry-builder is deprecated in favor of opm, this will need to be updated anyway. How often are these catalogs built with this Dockerfile? Probably not too often, as I think you would have seen these fail by now.
There was a problem hiding this comment.
Oh, sorry, I thought about another Dockerfile. This one we really could pin.
|
/retest |
Signed-off-by: Tom George <tgeorge@redhat.com>
Signed-off-by: Tom George <tgeorge@redhat.com>
Signed-off-by: Tom George <tgeorge@redhat.com>
Signed-off-by: Tom George <tgeorge@redhat.com>
Signed-off-by: Tom George <tgeorge@redhat.com>
Signed-off-by: Tom George <tgeorge@redhat.com>
|
@tolusha @AndrienkoAleksandr can you reapprove? |
…from new crd -> org_v1_che_crd.yaml Signed-off-by: Tom George <tgeorge@redhat.com>
|
@AndrienkoAleksandr made your requested fixes |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, tolusha, tomgeorge The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@tolusha @AndrienkoAleksandr Do you think this can this be merged today? |
+1 @tolusha ? |
|
+1 |
Changes:
Gopkg.lockandGopkg.tomlsigs.k8s.io/controller-runtime/pkg/runtime/signalsreplaced bysigs.k8s.io/controller-runtime/pkg/manager/signalsserializer.DirectCodecFactoryis renamed toserializer.WithoutConversionCodecFactorysigs.k8s.io/controller-runtime/pkg/runtime/schemereplaced bysigs.k8s.io/controller-runtime/pkg/schemepkg/apis/org/v1/zz_generated.openapi.goasoperator-sdk generate openapiis deprecated in favor ofoperator-sdk generate crdsDockerfilesinolmdirectory to correctly build test catalog imagesdeploy/crds/org.eclipse.che_checlusters_crd.yamlwhich contains the new openapi specs. I didn't delete the existing CRDs/CRs (org_v1_che_crd.yaml,org_v1_che_cr.yaml)Paths tested
chectlchectlThis is part of eclipse-che/che#18133