Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve oauth handling. #551

Merged
merged 17 commits into from
Dec 21, 2020
Merged

Improve oauth handling. #551

merged 17 commits into from
Dec 21, 2020

Conversation

AndrienkoAleksandr
Copy link
Contributor

What does this pull request do

Variant of the fix: enable oauth only if it's possible

Referenced iissue:

https://issues.redhat.com/browse/CRW-1361

Signed-off-by: Oleksandr Andriienko oandriie@redhat.com

@AndrienkoAleksandr AndrienkoAleksandr marked this pull request as draft November 24, 2020 07:49
@tolusha tolusha mentioned this pull request Nov 24, 2020
Closed
58 tasks
@tolusha tolusha marked this pull request as ready for review December 3, 2020 12:31
tolusha
tolusha reviewed Dec 3, 2020
View reviewed changes
Copy link
Contributor

@tolusha tolusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndrienkoAleksandr
Could you fix conflicts and update nightly bundles

@AndrienkoAleksandr
Copy link
Contributor Author

Could you fix conflicts and update nightly bundles?

Ok, I will

@AndrienkoAleksandr
Improve oauth handling.
f02c945 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
Copy link
Contributor Author

AndrienkoAleksandr commented Dec 3, 2020 •
edited
Loading

I resolved merge conflict and fixed tests failing. Also I want to apply few tests to cover some refactored parts. After that I will provide new CSV.

@tolusha tolusha mentioned this pull request Dec 7, 2020
Closed
56 tasks
@tolusha tolusha mentioned this pull request Dec 14, 2020
Closed
@AndrienkoAleksandr
Fix openshift version detection.
055cb0b 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
Enable oAuth for e2e test. e2e tests fails to create CheCR programati…
b69645e 
…cally with nil value. But with yamls it works...

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
tolusha
tolusha reviewed Dec 16, 2020
View reviewed changes
pkg/util/util.go Outdated Show resolved Hide resolved
@AndrienkoAleksandr
Handle code review requested changes.
9d8c34c 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
Merge remote-tracking branch 'upstream/master' into improveOAuthHandling
daca499
@AndrienkoAleksandr
Update openshiftOAuth property description. Update OLM bundle. Improv…
c2a1742 
…e Update Olm bundle dev task.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
tolusha
tolusha reviewed Dec 17, 2020
View reviewed changes
pkg/util/util.go Show resolved Hide resolved
pkg/controller/che/che_controller.go Show resolved Hide resolved
pkg/controller/che/che_controller.go Outdated Show resolved Hide resolved
pkg/controller/che/che_controller.go Outdated Show resolved Hide resolved
pkg/controller/che/che_controller.go Outdated Show resolved Hide resolved
pkg/controller/che/che_controller.go Outdated Show resolved Hide resolved
AndrienkoAleksandr and others added 3 commits December 17, 2020 14:37
@AndrienkoAleksandr @tolusha
Update pkg/controller/che/che_controller.go
5794c82 
Co-authored-by: Anatolii Bazko <abazko@redhat.com>
@AndrienkoAleksandr @tolusha
Update pkg/controller/che/che_controller.go
eb03b04 
Co-authored-by: Anatolii Bazko <abazko@redhat.com>
@AndrienkoAleksandr
Handle code review suggestions
16bf302 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@tolusha tolusha changed the title [Draft] Improve oauth handling. Improve oauth handling. Dec 17, 2020
tolusha
tolusha reviewed Dec 17, 2020
View reviewed changes
pkg/controller/che/che_controller.go Outdated Show resolved Hide resolved
pkg/controller/che/che_controller.go Outdated Show resolved Hide resolved
pkg/controller/che/che_controller.go Outdated Show resolved Hide resolved
pkg/controller/che/che_controller.go Outdated Show resolved Hide resolved
pkg/controller/che/che_controller.go Outdated Show resolved Hide resolved
AndrienkoAleksandr and others added 3 commits December 17, 2020 17:51
@AndrienkoAleksandr @tolusha
Update pkg/controller/che/che_controller.go
2c90889 
Co-authored-by: Anatolii Bazko <abazko@redhat.com>
@AndrienkoAleksandr
Handle pull request feedback.
1da8eb0 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
Handle pull request feedback.
279b025 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
Use test suite for oAuth tests.
adf5e50 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AndrienkoAleksandr AndrienkoAleksandr merged commit ae79476 into eclipse-che:master Dec 21, 2020
@AndrienkoAleksandr AndrienkoAleksandr deleted the improveOAuthHandling branch December 21, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolusha tolusha tolusha approved these changes

@davidfestal davidfestal Awaiting requested review from davidfestal

@nickboldt nickboldt Awaiting requested review from nickboldt

Assignees

@tolusha tolusha

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrienkoAleksandr @openshift-ci-robot @tolusha