Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential NPE #587

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Fix potential NPE #587

merged 1 commit into from
Dec 18, 2020

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Dec 17, 2020

Signed-off-by: Mykola Morhun mmorhun@redhat.com

What does this PR do?

Prevents potential NPE.
Fixes local debug command

What issues does this PR fix or reference?

eclipse-che/che#18474

@mmorhun mmorhun self-assigned this Dec 17, 2020
@AndrienkoAleksandr
Copy link
Contributor

@mmorhun I think check-nightly bundle force you to update bundles, because was released new ubi image... @tolusha What do you think about such case? Should we improve nigthly check to avoid force bundle update for this case?

tolusha
tolusha reviewed Dec 17, 2020
View reviewed changes
pkg/deploy/server/che_configmap.go Outdated Show resolved Hide resolved
pkg/deploy/server/che_configmap.go Outdated Show resolved Hide resolved
@tolusha
Copy link
Contributor

tolusha commented Dec 17, 2020

@AndrienkoAleksandr
No, this check is fine.

@mmorhun
Copy link
Contributor Author

mmorhun commented Dec 17, 2020

@tolusha we are going to ignore it, right?

@mmorhun
Fix potential NPE
b1aaf36 
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@openshift-merge-robot
Copy link

@mmorhun: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v7-che-operator-olm-nightly-deployment b1aaf36 link /test v7-che-operator-olm-nightly-deployment

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mmorhun mmorhun merged commit cdb613a into master Dec 18, 2020
@mmorhun mmorhun deleted the che-18474 branch December 18, 2020 12:07
@tolusha tolusha mentioned this pull request Dec 18, 2020
Closed
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrienkoAleksandr AndrienkoAleksandr AndrienkoAleksandr approved these changes

@tolusha tolusha tolusha approved these changes

@flacatus flacatus Awaiting requested review from flacatus

@davidfestal davidfestal Awaiting requested review from davidfestal

@nickboldt nickboldt Awaiting requested review from nickboldt

Assignees

@mmorhun mmorhun

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmorhun @AndrienkoAleksandr @tolusha @openshift-merge-robot @openshift-ci-robot