From 3672d0b56c60c7f3bca110a30d55efa7af16770a Mon Sep 17 00:00:00 2001 From: Anatolii Bazko Date: Wed, 13 Jan 2021 08:45:51 +0200 Subject: [PATCH 1/2] Add PR template Signed-off-by: Anatolii Bazko --- .github/PULL_REQUEST_TEMPLATE.md | 43 ++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000000..950a88d3b2 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,43 @@ + + +### What does this PR do? + + +### Screenshot/screencast of this PR + + + +### What issues does this PR fix or reference? + + + +### How to test this PR? + + + +### PR Checklist + +[As the author of this Pull Request I made sure that:](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#pull-request-template-and-its-checklist) + +- [ ] [The Eclipse Contributor Agreement is valid](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#the-eclipse-contributor-agreement-is-valid) +- [ ] [Code produced is complete](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#code-produced-is-complete) +- [ ] [Code builds without errors](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#code-builds-without-errors) +- [ ] [Tests are covering the bugfix](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#tests-are-covering-the-bugfix) +- [ ] [Custom resource definition file is updated](https://github.com/eclipse/che-operator/blob/master/README.md#updating-custom-resource-definition-file) +- [ ] [Nightly OLM bundle is updated](https://github.com/eclipse/che-operator/blob/master/README.md#update-nightly-olm-bundle) +- [ ] [The repository devfile is up to date and works](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#the-repository-devfile-is-up-to-date-and-works) +- [ ] [Sections `What issues does this PR fix or reference` and `How to test this PR` completed](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#sections-what-issues-does-this-pr-fix-or-reference-and-how-to-test-this-pr-completed) +- [ ] [Relevant user documentation updated](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#relevant-contributing-documentation-updated) +- [ ] [Relevant contributing documentation updated](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#relevant-contributing-documentation-updated) +- [ ] [CI/CD changes implemented, documented and communicated](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#cicd-changes-implemented-documented-and-communicated) + +### Reviewers + +Reviewers, please comment how you tested the PR when approving it. From 4a85e87084e930ba05c57a76438884ef092ce8be Mon Sep 17 00:00:00 2001 From: Anatolii Bazko Date: Wed, 13 Jan 2021 09:09:04 +0200 Subject: [PATCH 2/2] Minor changes Signed-off-by: Anatolii Bazko --- .github/PULL_REQUEST_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 950a88d3b2..064ce9e0c0 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -30,8 +30,8 @@ che-operator Development Guide: https://github.com/eclipse/che-operator/#develop - [ ] [Code produced is complete](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#code-produced-is-complete) - [ ] [Code builds without errors](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#code-builds-without-errors) - [ ] [Tests are covering the bugfix](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#tests-are-covering-the-bugfix) -- [ ] [Custom resource definition file is updated](https://github.com/eclipse/che-operator/blob/master/README.md#updating-custom-resource-definition-file) -- [ ] [Nightly OLM bundle is updated](https://github.com/eclipse/che-operator/blob/master/README.md#update-nightly-olm-bundle) +- [ ] [Custom resource definition file is up to date](https://github.com/eclipse/che-operator/blob/master/README.md#updating-custom-resource-definition-file) +- [ ] [Nightly OLM bundle is up to date](https://github.com/eclipse/che-operator/blob/master/README.md#update-nightly-olm-bundle) - [ ] [The repository devfile is up to date and works](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#the-repository-devfile-is-up-to-date-and-works) - [ ] [Sections `What issues does this PR fix or reference` and `How to test this PR` completed](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#sections-what-issues-does-this-pr-fix-or-reference-and-how-to-test-this-pr-completed) - [ ] [Relevant user documentation updated](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md#relevant-contributing-documentation-updated)