Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove che-theia, theia plugins and all references #1629

Merged
merged 11 commits into from
Mar 29, 2023
Merged

Conversation

svor
Copy link
Contributor

@svor svor commented Mar 28, 2023

What does this PR do?

  • Remove che-theia editor from the plugin registry
  • Remove che-theia plugins from the registry
  • Remove sidecars from the registry

screenshot-eclipse-che apps ci-ln-smm7kc2-76ef8 aws-2 ci openshift org-2023 03 28-17_21_22

screenshot-nimbusweb me-2023 03 29-16_44_28

What issues does this PR fix or reference?

eclipse-che/che#22090

How to test this PR?

Check the plugin registry content generated by this PR: https://pr-check-1629-che-plugin-registry.surge.sh/
If you want to start a workspace:

  • Use quay.io/vsvydenk/che-plugin-registry:no-theia image for plugin registry in CheCluster CRD
  • workspace with che-code should start

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Valerii Svydenko <vsvydenk@redhat.com>
Signed-off-by: Valerii Svydenko <vsvydenk@redhat.com>
Signed-off-by: Valerii Svydenko <vsvydenk@redhat.com>
Signed-off-by: Valerii Svydenko <vsvydenk@redhat.com>
Signed-off-by: Valerii Svydenko <vsvydenk@redhat.com>
Signed-off-by: Valerii Svydenko <vsvydenk@redhat.com>
Signed-off-by: Valerii Svydenko <vsvydenk@redhat.com>
Signed-off-by: Valerii Svydenko <vsvydenk@redhat.com>
Signed-off-by: Valerii Svydenko <vsvydenk@redhat.com>
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #1629 (3756450) into main (d874c08) will increase coverage by 6.31%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main     #1629      +/-   ##
===========================================
+ Coverage   93.68%   100.00%   +6.31%     
===========================================
  Files          47        21      -26     
  Lines        1457       563     -894     
  Branches      253        88     -165     
===========================================
- Hits         1365       563     -802     
+ Misses         92         0      -92     
Impacted Files Coverage Δ
tools/build/src/common/common-module.ts 100.00% <ø> (ø)
tools/build/src/common/container-helper.ts 100.00% <ø> (ø)
tools/build/src/common/volume-mount-helper.ts 100.00% <ø> (ø)
...ols/build/src/devfile/meta-yaml-to-devfile-yaml.ts 100.00% <ø> (ø)
tools/build/src/editor/che-editors-analyzer.ts 100.00% <ø> (ø)
...uild/src/editor/che-editors-meta-yaml-generator.ts 100.00% <ø> (ø)
tools/build/src/editor/editor-module.ts 100.00% <ø> (ø)
tools/build/src/entrypoint.ts 100.00% <ø> (ø)
tools/build/src/inversify-binding.ts 100.00% <ø> (ø)
tools/build/src/main.ts 100.00% <ø> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nickboldt nickboldt self-requested a review March 28, 2023 12:57
Signed-off-by: Valerii Svydenko <vsvydenk@redhat.com>
Signed-off-by: Valerii Svydenko <vsvydenk@redhat.com>
## Prerequisites
- nodejs 14.x and yarn v1
- nodejs 14.x and yarn v3.x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need a yarn v1 lock file for cachito, though :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be a part of another PR

@openshift-ci
Copy link

openshift-ci bot commented Mar 29, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, svor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@svor svor merged commit aea518a into main Mar 29, 2023
@svor svor deleted the sv-remove-theia branch March 29, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants