Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add volumes, resource limits, endpoints, and envs #722

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Add volumes, resource limits, endpoints, and envs #722

merged 1 commit into from
Dec 1, 2020

Conversation

ericwill
Copy link
Contributor

@ericwill ericwill commented Dec 1, 2020

Signed-off-by: Eric Williams ericwill@redhat.com

What does this PR do?

Adds the volume, endpoint, env, and resource limit entries to the che-theia-plugins.yaml file.

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

Part of eclipse-che/che#18215

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

che-theia-plugins.yaml Outdated Show resolved Hide resolved
che-theia-plugins.yaml Outdated Show resolved Hide resolved
Part of eclipse-che/che#18215

Signed-off-by: Eric Williams <ericwill@redhat.com>
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ericwill
Copy link
Contributor Author

ericwill commented Dec 1, 2020

Looks like GitHub action is having an outage of some kind: https://www.githubstatus.com/incidents/sxthxvdlljk4

@benoitf
Copy link
Contributor

benoitf commented Dec 1, 2020

I've restarted jobs

@ericwill ericwill merged commit 8974142 into eclipse-che:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants