fix(che-editors): Add missing entries in che-editors.yaml and fix couple of issues on volumes/exposedPort/id #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
requested review from
ericwill,
sunix,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
svor
reviewed
Dec 15, 2020
…ple of issues on volumes/exposedPort/id Change-Id: Ifd930bef786e1bcac819a66a18838b0831e568ef Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
force-pushed
the
add-missing-plugin
branch
from
d2e9153 to
fe85431
Compare
svor
approved these changes
Dec 15, 2020
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add some missing information to generate meta.yaml
For che-theia-plugins.yaml we were not adding some information as it's available from inside the vsix files but with editors there is no other source, so need to add the details.
Fix volumeMount name to match che-theia-plugins.yaml volumeMount declaration
Also some ids were not matchings the ids of the current plug-ins
Screenshot/screencast of this PR
What issues does this PR fix or reference?
che-editors.yaml was introduced as part of eclipse-che/che#18214
How to test this PR?
For now this
che-editors.yamlfile is not used but an upcoming PR will process this file.PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.
Change-Id: Ifd930bef786e1bcac819a66a18838b0831e568ef
Signed-off-by: Florent Benoit fbenoit@redhat.com