Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java-plugins): update vscode-java and vscode-java-test for all java11 related plugins #890

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

sunix
Copy link
Contributor

@sunix sunix commented Mar 19, 2021

What does this PR do?

Update vscode-java (jdt-ls) and vscode-java-test to the latest.

Screenshot/screencast of this PR

Selection_279

What issues does this PR fix or reference?

Fix eclipse-che/che#19099

How to test this PR?

This is a devfile using java plugin from the updated registry. Make sure Java feature all works fine, as well as unit tests.

apiVersion: 1.0.0
metadata:
  generateName: test-java-extension-update-
attributes:
  multiRoot: 'on'
projects:
  - name: java-web-spring
    source:
      location: 'https://github.com/spring-projects/spring-petclinic.git'
      type: git
      commitId: 4953f87917b449a404a7f1f4e2457836b9eafbbc
  - name: event-publisher
    source:
      location: 'https://github.com/parisjug/event-publisher'
      type: git
components:
  - id: redhat/java/latest
    preferences:
      java.server.launchMode: Standard
    registryUrl: 'https://sunix-plugin-registry-update-java-gbjp9.surge.sh/v3'
    type: chePlugin
  - mountSources: true
    endpoints:
      - name: 8080-tcp
        port: 8080
      - attributes:
          public: 'false'
        name: debug
        port: 5005
    memoryLimit: 768Mi
    type: dockerimage
    volumes:
      - name: m2
        containerPath: /home/user/.m2
    image: 'quay.io/eclipse/che-java11-maven:nightly'
    alias: tools
    env:
      - value: ''
        name: MAVEN_CONFIG
      - value: '-XX:MaxRAMPercentage=50.0 -XX:+UseParallelGC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90 -Dsun.zip.disableMemoryMapping=true -Xms20m -Djava.security.egd=file:/dev/./urandom -Duser.home=/home/user'
        name: JAVA_OPTS
      - value: $(JAVA_OPTS)
        name: MAVEN_OPTS
commands:
  - name: maven build
    actions:
      - workdir: '${CHE_PROJECTS_ROOT}/java-web-spring'
        type: exec
        command: mvn clean install
        component: tools
  - name: run webapp
    actions:
      - workdir: '${CHE_PROJECTS_ROOT}/java-web-spring'
        type: exec
        command: |
          java -jar -Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=5005 \
          target/*.jar
        component: tools
  - name: Debug remote java application
    actions:
      - referenceContent: |
          {
          "version": "0.2.0",
          "configurations": [
            {
              "type": "java",
              "name": "Debug (Attach) - Remote",
              "request": "attach",
              "hostName": "localhost",
              "port": 5005
            }]
          }
        type: vscode-launch

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

…ava11 related plugins

Signed-off-by: Sun Tan <sutan@redhat.com>
@benoitf
Copy link
Contributor

benoitf commented Mar 19, 2021

Hello, it looks like it's missing updates on revision fields

Signed-off-by: Sun Tan <sutan@redhat.com>
@sunix sunix force-pushed the java-ext-update branch from c81f39a to 0614d1e Compare March 19, 2021 12:59
@sunix
Copy link
Contributor Author

sunix commented Mar 19, 2021

Hello, it looks like it's missing updates on revision fields

@benoitf should be fixed

Copy link
Contributor

@ericwill ericwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 but looks like GitHub actions are stalled again

@sunix sunix merged commit c52dccc into master Mar 22, 2021
@sunix sunix deleted the java-ext-update branch March 22, 2021 09:37
@sunix
Copy link
Contributor Author

sunix commented Mar 22, 2021

Merging as there is no shell script changes in that PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade the Java stack
3 participants