-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend the raw devfile url pattern with Bitbucket server query parameter #732
Conversation
@artaleks9 could you please take a look at the failing test |
/retest |
Verified on Eclipse Che using The functionality works properly. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: artaleks9, ibuziuk, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.18 :: server_3.x/368: Console, Changes, Git Data |
Build 3.18 :: sync-to-downstream_3.x/7945: Console, Changes, Git Data |
Build 3.18 :: push-latest-container-to-quay_3.x/5014: Console, Changes, Git Data |
Build 3.18 :: get-sources-rhpkg-container-build_3.x/8021: server : 3.x :: Build 65489976 : quay.io/devspaces/server-rhel8:3.18-7 |
Build 3.18 :: update-digests_3.x/7875: Console, Changes, Git Data |
Build 3.18 :: server_3.x/368: Upstream sync done; /DS_CI/sync-to-downstream_3.x/7945 triggered |
Build 3.18 :: operator-bundle_3.x/3754: Console, Changes, Git Data |
Build 3.18 :: sync-to-downstream_3.x/7946: Console, Changes, Git Data |
Build 3.18 :: get-sources-rhpkg-container-build_3.x/8022: devspaces-operator-bundle : 3.x :: Failed in 65491010 : BREW:BUILD/STATUS:UNKNOWN |
What does this PR do?
Extend the raw devfile url pattern with Bitbucket server query parameter. This fixes an issue that starting a workspace from a raw devfile url from private Bitbucket server repository shows a wrong error:
The error is about wrong oauth configuration but it is reproduced without any oauth configurations at all.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#23158
How to test this PR?
quay.io/eclipse/che-server:pr-732
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedRelease Notes
Reviewers
Reviewers, please comment how you tested the PR when approving it.