Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the raw devfile url pattern with Bitbucket server query parameter #732

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Oct 28, 2024

What does this PR do?

Extend the raw devfile url pattern with Bitbucket server query parameter. This fixes an issue that starting a workspace from a raw devfile url from private Bitbucket server repository shows a wrong error:
screenshot-eclipse-che_apps_rosa_wgjtd-8at7g-nku_afgo_p3_openshiftapps_com-2024_10_28-14_05_55
The error is about wrong oauth configuration but it is reproduced without any oauth configurations at all.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#23158

How to test this PR?

  1. Deploy che with the PR image: quay.io/eclipse/che-server:pr-732
  2. Get a Raw devfile url from a PRIVATE Bitbucket server repository.
  3. Start a workspace from the raw devfile url.
  4. See: the workspace start interrupts with the error:
    screenshot-eclipse-che_apps_rosa_wgjtd-8at7g-nku_afgo_p3_openshiftapps_com-2024_10_28-13_58_35

PR Checklist

As the author of this Pull Request I made sure that:

Release Notes

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@ibuziuk
Copy link
Member

ibuziuk commented Oct 28, 2024

@artaleks9 could you please take a look at the failing test

@artaleks9
Copy link
Contributor

/retest

@artaleks9
Copy link
Contributor

Verified on Eclipse Che using quay.io/eclipse/che-server:pr-732

The functionality works properly.

Copy link

openshift-ci bot commented Oct 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: artaleks9, ibuziuk, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vinokurig vinokurig merged commit 14f7556 into main Oct 29, 2024
28 checks passed
@vinokurig vinokurig deleted the che-23158 branch October 29, 2024 12:16
@devstudio-release
Copy link

Build 3.18 :: server_3.x/368: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.18 :: server_3.x/368: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7945 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.18 :: get-sources-rhpkg-container-build_3.x/8022: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 65491010 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected warning message while try to start a workspace from a raw devfile
4 participants