Export configurations from devfile in a launch.json and tasks.json files #218
Conversation
|
The PR provides ability to export launch configurations in a launch.json file. |
|
Would you add a demo of that new feature? |
|
I'm going to update the PR - add ability to export tasks configurations in tasks.json file and then provide demo for both cases |
RomanNikitenko
force-pushed
the
configurations
branch
from
7a1d916 to
2704f52
Compare
RomanNikitenko
changed the title
RomanNikitenko
requested review from
olexii4,
sunix and
vitaliy-guliy
as code owners
RomanNikitenko
force-pushed
the
configurations
branch
from
2704f52 to
b458583
Compare
|
For reviewers: I had to push with force to resolve conflicts, sorry about that... |
…older Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
RomanNikitenko
force-pushed
the
configurations
branch
from
b458583 to
f234cbe
Compare
|
@RomanNikitenko @olexii4 Let me make sure. Can I merge this PR? |
|
I created the issue for improving way of merging tasks configurations https://github.com/eclipse/che-theia/issues/248 |
|
@monaka |
What does this PR do?
It's expected that configurations are presented in the format.
The current implementation supports the merge existed configurations from config file and configs from devfile. Configurations from devfile have higher priority than existed configs in config file.
So, if you already have configs in launch.json file, for example, the configs with the same label will be replaced by configs from devfile.
About export tasks configurations in tasks.json file.
In the PR I rely that
referenceContentforvscode-tasktype action contains ready to use configurations(in vs code format) - we don’t convert them and we just copy content to tasks.json file (if tasks.json file is absent or doesn’t contain configs) or merge with existed configs.Another actions from commands section of devfile are che commands - we don’t copy them to tasks.json file, but convert them to theia tasks. They are available for running from UI as ‘detected’.
What issues does this PR fix or reference?
eclipse-che/che#12711
Related issue: eclipse-che/che#13057
Please see video: https://youtu.be/8H8dLju0Goc