Remote binary #267
Remote binary #267
Conversation
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr
requested review from
benoitf,
evidolob,
mmorhun and
akurinnoy
| @@ -22,6 +22,13 @@ const localModule = ConnectionContainerModule.create(({ bind }) => { | |||
| }); | |||
|
|
|||
| export default new ContainerModule(bind => { | |||
| try { | |||
| // Force nexe to include theia-plugin-ext iside binary | |||
|
|
||
| echo "Copying ${base_dir}/../../extensions/eclipse-che-theia-plugin --> ${LOCAL_ASSEMBLY_DIR}/theia-plugin" | ||
| mkdir ${LOCAL_ASSEMBLY_DIR}/theia-plugin | ||
| cp -r "${base_dir}/../../extensions/eclipse-che-theia-plugin/src/." "${LOCAL_ASSEMBLY_DIR}/theia-plugin/src/" |
There was a problem hiding this comment.
Maybe it is worth to create another constant which holds ${base_dir}/../../ ? But up to you.
| fi \ | ||
| fi | ||
|
|
||
| #invalidate cashe |
| RUN rm -rf /home/workspace/node_modules/@eclipse-che/theia-plugin-ext /home/workspace/node_modules/@eclipse-che/theia-remote | ||
| RUN cp -rf /home/workspace/packages/theia-plugin-ext /home/workspace/node_modules/@eclipse-che/theia-plugin-ext | ||
|
|
||
| RUN nexe packages/theia-remote/lib/node/plugin-remote.js -t alpine-x64-10.14.2 -o plugin-remote |
There was a problem hiding this comment.
is that the binary is running on pure alpine image after that ? AFAIK there was still some mandatory libraries required to run on a plain alpine image
There was a problem hiding this comment.
Hmm... I tested two remote plugins: typescript and my custom with this binary on the pure alpine - they were working... 99ae354#diff-f7eaf7e082319e42b2dfd26a86ca0736R80
Could you elaborate more about mandatory libraries ?
There was a problem hiding this comment.
alpine image is just alpine:latest or was there some other packages installed?
my attempt was with pkg and not nexe so it might different, it was requiring libstdc++ package
vercel/pkg#555
|
|
||
| @injectable() | ||
| export class ChePluginApiProvider implements ExtPluginApiProvider { | ||
|
|
||
| provideApi(): ExtPluginApi { | ||
| console.log('provide che plugin api!!!'); |
| return { | ||
| frontendExtApi: { | ||
| initPath: '/che/api/che-api-worker-provider.js', | ||
| initFunction: 'initializeApi', | ||
| initVariable: 'che_api_provider' | ||
| }, | ||
| backendInitPath: path.join(__dirname, '../plugin/node/che-api-node-provider.js') | ||
| backendInitPath: '@eclipse-che/theia-plugin-ext/lib/plugin/node/che-api-node-provider.js' |
There was a problem hiding this comment.
in theia, we don't have path.join as well anymore ?
There was a problem hiding this comment.
I don't see no more api providers in the theia repo, only in the README.md: https://github.com/theia-ide/theia/blob/master/packages/plugin-ext/doc/how-to-add-new-plugin-namespace.md#declare-extpluginapiprovider-implementation
There was a problem hiding this comment.
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
|
Closed on favour #410 |
What does this PR do?
Add image with remote-plugin-endpoint binary
What issues does this PR fix or reference?
eclipse-che/che#13387