Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Remove HTML/CSS integration by Monaco in favor of the corresponding VS Code built-ins #793

Merged
merged 3 commits into from
Jul 6, 2020

Conversation

azatsarynnyy
Copy link
Member

Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com

What does this PR do?

Adapts to upstream changes eclipse-theia/theia#7972 - removes HTML/CSS integration from Monaco in favor of the corresponding VS Code built-ins.

What issues does this PR fix or reference?

fixes eclipse-che/che#17332

Release Notes

Docs PR

… VS Code built-ins.

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
@azatsarynnyy azatsarynnyy marked this pull request as ready for review July 6, 2020 10:40
@eclipse-che eclipse-che deleted a comment from che-bot Jul 6, 2020
@che-bot
Copy link
Contributor

che-bot commented Jul 6, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:793
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:793

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@azatsarynnyy azatsarynnyy merged commit 1bcf62a into master Jul 6, 2020
@azatsarynnyy azatsarynnyy deleted the fix-monaco branch July 6, 2020 11:29
@l0rd l0rd added the new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes label Jul 7, 2020
@azatsarynnyy azatsarynnyy changed the title Remove HTML/CSS integration from Monaco in favor of the corresponding VS Code built-ins Remove HTML/CSS integration by Monaco in favor of the corresponding VS Code built-ins Jul 13, 2020
@che-bot
Copy link
Contributor

che-bot commented Jul 13, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:793
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:793

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

benoitf added a commit to benoitf/che-theia that referenced this pull request Aug 17, 2020
…clipse-che#793

Fixes eclipse-che/che#17643

Change-Id: I69ad1eba4e428c4f9b59c504d77ece0fd8d665d4
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit that referenced this pull request Aug 17, 2020
…793

Fixes eclipse-che/che#17643

Change-Id: I69ad1eba4e428c4f9b59c504d77ece0fd8d665d4
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
vinokurig pushed a commit that referenced this pull request Apr 6, 2021
* Add default kubernetes labels

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate why Che Theia build fails on CI
4 participants