Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework JwtProxyConfigBuilder to use Objects instead of formatting string config template #10402

Closed
sleshchenko opened this issue Jul 12, 2018 · 1 comment
Assignees
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it.

Comments

@sleshchenko
Copy link
Member

Description

As a sequel of the following discussion #10252 (comment)

It is needed to rework JwtProxyConfigBuilder to use Objects instead of formatting string config template.

So, it includes:

@sleshchenko sleshchenko added status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. kind/task Internal things, technical debt, and to-do tasks to be performed. team/platform labels Jul 12, 2018
@sleshchenko
Copy link
Member Author

Also, I think it makes sense not make configurable jwtproxy configuration properties that now are hardcoded. Like, verifier.max_skew, verifier.max_ttl, jwt proxy image and maybe other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it.
Projects
None yet
Development

No branches or pull requests

3 participants