-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jwt-proxy is displayed as machine on IDE UI #10521
Comments
We should probably mark/tag such machines somehow, so that clients can filter machines accordingly. |
I don't think this is a bug either |
@skabashnyuk Could you elaborate why do you think so? How is it possible to execute a command in a machine where @eivantsov Do you mean marking for hiding such machines at all? In the specific case, IDE can filter machines which don't have |
We will figure out that with Theia based ide. |
Good point. I don't think that it changes the kind of issue but I agree with you about it. BTW It is not a critical issue since |
Ok. let's reformulate issue. Do not show machine without exec agent for the command execution target. WDYT? |
There is an issue for marking tooling machines with a special attribute #11804 |
Issues go stale after Mark the issue as fresh with If this issue is safe to close now please do so. Moderators: Add |
Description
In this PR (#10463) @mshaposhnik add a "jwt-proxy" functionality.
The problem is the "jwt-proxy" displays as the machine in the workspace. It leads to regression (almost 20 %) in the tests which oriented to the using of the workspace with a single machine and unexpected machine selection dialog causes the fails:
Besides it looks veard for user which expects single machine in his workspace. And as @sleshchenko wrote in the ##10463 the "jwt-proxy" doesn't have terminal, or exec-agent servers. @vparfonov could you clarify this issue?
Test report with reproduced bug:
https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/505/Selenium_20tests_20report/
The text was updated successfully, but these errors were encountered: