Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jwt-proxy is displayed as machine on IDE UI #10521

Closed
Ohrimenko1988 opened this issue Jul 24, 2018 · 8 comments
Closed

Jwt-proxy is displayed as machine on IDE UI #10521

Ohrimenko1988 opened this issue Jul 24, 2018 · 8 comments
Labels
kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@Ohrimenko1988
Copy link
Contributor

Ohrimenko1988 commented Jul 24, 2018

Description

In this PR (#10463) @mshaposhnik add a "jwt-proxy" functionality.
The problem is the "jwt-proxy" displays as the machine in the workspace. It leads to regression (almost 20 %) in the tests which oriented to the using of the workspace with a single machine and unexpected machine selection dialog causes the fails:

fffff

Besides it looks veard for user which expects single machine in his workspace. And as @sleshchenko wrote in the ##10463 the "jwt-proxy" doesn't have terminal, or exec-agent servers. @vparfonov could you clarify this issue?

Test report with reproduced bug:
https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/505/Selenium_20tests_20report/

@Ohrimenko1988 Ohrimenko1988 added kind/bug Outline of a bug - must adhere to the bug report template. team/ide severity/P1 Has a major impact to usage or development of the system. labels Jul 24, 2018
@ghost
Copy link

ghost commented Jul 25, 2018

We should probably mark/tag such machines somehow, so that clients can filter machines accordingly.

@skabashnyuk skabashnyuk removed kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. labels Jul 30, 2018
@skabashnyuk
Copy link
Contributor

I don't think this is a bug either

@sleshchenko
Copy link
Member

@skabashnyuk Could you elaborate why do you think so? How is it possible to execute a command in a machine where exec server is not present?

@eivantsov Do you mean marking for hiding such machines at all? In the specific case, IDE can filter machines which don't have exec server.

@skabashnyuk
Copy link
Contributor

@skabashnyuk Could you elaborate why do you think so? How is it possible to execute a command in a machine where exec server is not present?

We will figure out that with Theia based ide.
My point: we should not spend much time with new components with GWT based IDE.

@sleshchenko
Copy link
Member

@skabashnyuk

we should not spend much time with new components with GWT based IDE.

Good point. I don't think that it changes the kind of issue but I agree with you about it.
I don't think that it requires a lot of time to fix this issue.

BTW It is not a critical issue since jwtproxy is disabled by default but it would be fixed before enabling jwtproxy by default.

@skabashnyuk
Copy link
Contributor

Ok. let's reformulate issue. Do not show machine without exec agent for the command execution target. WDYT?

@vkuznyetsov vkuznyetsov added kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system. labels Aug 9, 2018
@sleshchenko
Copy link
Member

There is an issue for marking tooling machines with a special attribute #11804

@sleshchenko sleshchenko changed the title Jwt-proxy displays as machine on IDE UI Jwt-proxy is displayed as machine on IDE UI Dec 3, 2018
@che-bot
Copy link
Contributor

che-bot commented Sep 7, 2019

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 7, 2019
@che-bot che-bot closed this as completed Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants