Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open a preview URL in an embedded panel in Theia #10738

Closed
azatsarynnyy opened this issue Aug 10, 2018 · 5 comments
Closed

Open a preview URL in an embedded panel in Theia #10738

azatsarynnyy opened this issue Aug 10, 2018 · 5 comments
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template. sprint/current

Comments

@azatsarynnyy
Copy link
Member

The issue based on the discussion #8974 (comment)

For now, a preview URL for a running command can be opened in a separate browser's tab only.
It'd be useful to have both options available: open URL in a separate tab or open URL inside Theia.

@azatsarynnyy azatsarynnyy added kind/enhancement A feature request - must adhere to the feature request template. team/ide labels Aug 10, 2018
@azatsarynnyy
Copy link
Member Author

azatsarynnyy commented Aug 28, 2018

To keep track of the progress more transparently here's the subtasks I plan to work on:

Preview URLs panel:

  • Implement a Preview URLs panel, at the bottom, to display all the preview URLs. Temporary, a list of the URLs will be updated on each panel opening. Preview URLs panel can be opened via a widget on the status panel.
  • A preview URL can be opened in a separate browser's tab.
  • Preview URL list is synchronized with the running tasks automatically.

Preview panel - internal mini-browser:

  • Implement a Preview panel, at the right, with an embedded mini-browser that can open a URL.
  • Make it possible to open any preview URL in a Preview panel.

Preview URL notifications:

  • Notifications are shown, at the top, as soon as a che-task is running and propose to open a related preview URL (internally or externally).

Preferences:

  • By default, a user should be asked how to open a preview URL: internally or externally.
  • A user should be able to choose a preview URL opening behavior in the Theia preferences:
    • ask everytime
    • always open internally
    • always open externally
    • never open a preview URL automatically

CC: @vparfonov @slemeur

@benoitf
Copy link
Contributor

benoitf commented Sep 5, 2018

is it done through Theia plug-in webview ?

@azatsarynnyy
Copy link
Member Author

@benoitf no, it's done through Theia extension view contribution

@slemeur
Copy link
Contributor

slemeur commented Sep 5, 2018

must be with the plugin API

@azatsarynnyy
Copy link
Member Author

Subtasks list has been updated after the discussion with @slemeur

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. sprint/current
Projects
None yet
Development

No branches or pull requests

4 participants