Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebDriverWait Instances Should not be Shared #11149

Closed
tsmaeder opened this issue Sep 10, 2018 · 2 comments
Closed

WebDriverWait Instances Should not be Shared #11149

tsmaeder opened this issue Sep 10, 2018 · 2 comments
Assignees
@dmytro-ndp
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.

Comments

@tsmaeder
Copy link
Contributor

In reponse to this issue: #8472, web driver waits are shared. However, instances of WebDriverWait can be customized (with custom message providers, for example). This can lead to bogus messages for test failures Was such, I don't think they are made to be shared. Is there a reason we are sharing the WebDriverWait instances? The linked issue gives no explanation.
@dmytro-ndp dmytro-ndp self-assigned this Sep 10, 2018
@dmytro-ndp dmytro-ndp added kind/task Internal things, technical debt, and to-do tasks to be performed. status/in-progress This issue has been taken by an engineer and is under active development. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Sep 10, 2018
@dmytro-ndp
Copy link
Contributor

WebDriverWait instances are sharing to reduce number of it's instantiation during the selenium tests execution. The only difference we have between the instances is a timeout. It isn't expected that there could be another difference like the error message supplier.

@dmytro-ndp dmytro-ndp added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach labels Sep 10, 2018
@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Sep 10, 2018 •
edited
Loading

If we a setting up message supplier in addition to timeout, it increases complexity of WebDriverWaitFactory. In that case it would make sense not to share instances at all.

@dmytro-ndp dmytro-ndp mentioned this issue Sep 10, 2018
Merged
@dmytro-ndp dmytro-ndp removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 11, 2018
@vkuznyetsov vkuznyetsov mentioned this issue Sep 11, 2018
Closed
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmytro-ndp dmytro-ndp

Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmytro-ndp @tsmaeder