Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Che + theia: Theia IDE do not send any activity events to wsmaster #11267

Closed
sunix opened this issue Sep 18, 2018 · 5 comments
Closed

Che + theia: Theia IDE do not send any activity events to wsmaster #11267

sunix opened this issue Sep 18, 2018 · 5 comments
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@sunix
Copy link
Contributor

sunix commented Sep 18, 2018

Description

When using Theia in Che and having CHE_WORKSPACE_AGENT_DEV_INACTIVE__STOP__TIMEOUT__MS being set, workspace is killed after that time even if there is some activity in Che Theia IDE.

Reproduction Steps

In http://che.openshift.io, create a workspace using a theia stack for instance https://che.openshift.io/dashboard/#/factory/factorywj3405v4cnxdjmln. After 15 minutes, even if the user is working editing files or doing anything else, the workspace is being killed.

@sunix sunix added kind/bug Outline of a bug - must adhere to the bug report template. team/ide2 labels Sep 18, 2018
@sunix
Copy link
Contributor Author

sunix commented Sep 18, 2018

@sunix
Copy link
Contributor Author

sunix commented Sep 19, 2018

will we have CORS issue with that as well ? Could dashboard side bar track that instead of theia ?

@skabashnyuk
Copy link
Contributor

@sunix can you consolidate all API on master on which you need CORS and create an issue for that?

@ashumilova ashumilova added the severity/P1 Has a major impact to usage or development of the system. label Sep 19, 2018
@garagatyi
Copy link

In the future, it would be better to send the activity from the backend. This is part that makes sense to be compiled into the Che-Theia assembly or be added as a default plugin.
Now we can work around that with CORS exclusion, but it is kinda a flow when a user would be able to ping his WS from some cron job on his own computer.

@mmorhun
Copy link
Contributor

mmorhun commented Oct 1, 2018

Done.
Activity checker is added as Theia extension.
Requests to workspace master are performed from backend.
Both frontend and backend are optimized to send minimal amount of requests.

@mmorhun mmorhun closed this as completed Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants