Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve che-plugin.yaml] Use of the property mountProjectSources (or even the simpler mountSources) for a tool/plugin #12413

Closed
2 tasks
skabashnyuk opened this issue Jan 14, 2019 · 5 comments
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.

Comments

@skabashnyuk
Copy link
Contributor

skabashnyuk commented Jan 14, 2019

Description

This issue is created as result of the following discussion redhat-developer/devfile#2 (comment)

Now if plugin developer wants to get projects sources mounted to his plugin then he has to define volume with name projects and path /projects.

version: 1.0.0
type: Che Editor
name: theia-ide
id: org.eclipse.che.editor.theia
endpoints:
       ...
containers:
 - name: theia-ide
   image: eclipse/che-theia:0.3.18-nightly
   env:
       ...
   volumes:
       - mountPath: "/projects"
         name: projects
       - mountPath: "/plugins"
         name: plugins
   ports:
       ...

The idea of this issue is simplify defining of mounting projects sources to the following format:

version: 1.0.0
type: Che Editor
name: theia-ide
id: org.eclipse.che.editor.theia
endpoints:
       ...
containers:
 - name: theia-ide
   image: eclipse/che-theia:0.3.18-nightly
   env:
       ...
   volumes:
       - mountPath: "/plugins"
         name: plugins
   mountSources: true // false
   ports:
       ...

should define project volumes
The idea of this issue is avoid defining projects volume by user/plugin developer.

The scope of this issue includes:

  • Made Che Server respecting this flag and provision projects volume automatically with /projects path specified. Note that the solution should be back forward compatible and plugins that are configured in old way (with projects volume specified) should work. It may be implemented by taking mountSources into account only when projects volume is missing;
  • Update field name in dockerimage tool when final name decision about mountSources/mountProjectSources will be made. See https://github.com/redhat-developer/devfile/blob/master/Devfile.yaml;
@skabashnyuk skabashnyuk added kind/task Internal things, technical debt, and to-do tasks to be performed. team/platform labels Jan 14, 2019
@skabashnyuk skabashnyuk changed the title Use of the property mountProjectSources (or even the simpler mountSources) for a tool/plugin [Improve che-plugin.yaml] Use of the property mountProjectSources (or even the simpler mountSources) for a tool/plugin Jan 14, 2019
@sleshchenko
Copy link
Member

The detailed implementation plan is added to the issue description.

@metlos
Copy link
Contributor

metlos commented Jan 21, 2019

Should the attribute be named mountProjectSources?

@metlos
Copy link
Contributor

metlos commented Jan 21, 2019

Should the attribute be named mountSources?

@metlos
Copy link
Contributor

metlos commented Jan 23, 2019

as per https://www.eclipse.org/lists/che-dev/msg03002.html I will go ahead and create new issues for the more fine-grained tasks towards implementing the agreed solution.

@metlos
Copy link
Contributor

metlos commented Jan 30, 2019

Superseded by #12510

@metlos metlos closed this as completed Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

No branches or pull requests

3 participants