Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UD should show warning if plugin is deprecated #13021

Closed
garagatyi opened this issue Mar 29, 2019 · 5 comments
Closed

UD should show warning if plugin is deprecated #13021

garagatyi opened this issue Mar 29, 2019 · 5 comments
Assignees
@olexii4 @mmorhun
Labels
area/dashboard kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone
7.3.0

Comments

@garagatyi
Copy link

garagatyi commented Mar 29, 2019 •
edited
Loading

Description

When plugin enabled in a workspace is deprecated:

publisher: plugin_publisher
id: plugin_id
version: 1.2.3
name: Some plugin
deprecate:
   autoMigrate: true
   migrateTo: another_publisher/another_plugin_id:1.0.0

UD should show a sign (probably exclamation mark) on plugin that have this section and explain that these plugins are deprecated and it is better to migrate to plugin specified in deprecate.migrateTo.

See more details at eclipse-che/che-plugin-registry#55 (comment)
@evidolob evidolob mentioned this issue Apr 23, 2019
Closed
50 tasks
@nickboldt
Copy link
Contributor

Does this still apply for Che 7 with the latest plugin/devfile registry versions?

If so, seems like a good idea for Che 7.1.

@nickboldt nickboldt added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 31, 2019
@benoitf benoitf added this to the 7.2.0 milestone Aug 5, 2019
@benoitf benoitf added team/ide2 area/dashboard kind/enhancement A feature request - must adhere to the feature request template. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 5, 2019
@evidolob evidolob mentioned this issue Aug 28, 2019
Closed
20 tasks
@sunix
Copy link
Contributor

sunix commented Sep 4, 2019

step1: make sure that deprecate field is displayed in the list of plugins of the plugin registry. If it is not displayed, create an issue to have it available.
step2: show the deprecate field in the dashboard as a warning

@vitaliy-guliy vitaliy-guliy mentioned this issue Sep 4, 2019
Closed
@sunix sunix mentioned this issue Sep 18, 2019
Closed
21 tasks
@sunix sunix added the severity/P2 Has a minor but important impact to the usage or development of the system. label Sep 18, 2019
@mmorhun
Copy link
Contributor

mmorhun commented Sep 20, 2019

To be able to display warning on dashboard side, deprecated plugins should have a mark in index.json file of the plugin registry. I plan to add field deprecated: true only for deprecated plugins.

@mmorhun
Copy link
Contributor

mmorhun commented Sep 23, 2019

After some discussions we decided to add whole deprecate field into index.json

@mmorhun mmorhun mentioned this issue Sep 23, 2019
Merged
@mmorhun
Copy link
Contributor

mmorhun commented Sep 23, 2019

@olexii4 backend part is done

@olexii4 olexii4 mentioned this issue Sep 29, 2019
Merged
@evidolob evidolob modified the milestones: 7.2.0, 7.3.0 Oct 2, 2019
@olexii4 olexii4 closed this as completed Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olexii4 olexii4

@mmorhun mmorhun

Labels
area/dashboard kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
7.3.0
Development

No branches or pull requests
7 participants
@nickboldt @benoitf @sunix @evidolob @garagatyi @olexii4 @mmorhun