Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After restart Eclipse CHE workspace che-theia should not open empty terminals #13167

Closed
AndrienkoAleksandr opened this issue Apr 16, 2019 · 2 comments
Closed

After restart Eclipse CHE workspace che-theia should not open empty terminals #13167

AndrienkoAleksandr opened this issue Apr 16, 2019 · 2 comments
Labels
kind/bug Outline of a bug - must adhere to the bug report template. kind/enhancement A feature request - must adhere to the feature request template.

Comments

@AndrienkoAleksandr
Copy link
Contributor

Description

After restart workspace che-theia tries to restore empty terminals. We need store container name and after restart workspace use this info to create new one terminal for corresponding container. In case fail - collapse terminal widget.

Reproduction Steps

  1. Start workspace created from che-theia stack.
  2. Create new terminal for dev container.
  3. Stop workspace.
  4. Start workspace again and open che-theia.

Actual result: Theia opens empty terminal widget.
Expected result: Theia should create new one terminal for dev container - "some kind of restore", or don't open empty terminal widgets at all.
@AndrienkoAleksandr AndrienkoAleksandr added kind/bug Outline of a bug - must adhere to the bug report template. kind/enhancement A feature request - must adhere to the feature request template. team/ide2 labels Apr 16, 2019
@evidolob evidolob mentioned this issue Jun 6, 2019
Closed
29 tasks
@ashumilova ashumilova mentioned this issue Jul 2, 2019
Closed
16 tasks
@evidolob evidolob mentioned this issue Jul 2, 2019
Closed
26 tasks
@che-bot
Copy link
Contributor

che-bot commented Oct 18, 2019

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 18, 2019
@AndrienkoAleksandr AndrienkoAleksandr removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 18, 2019
@azatsarynnyy
Copy link
Member

closing it as cannot reproduce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template. kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@azatsarynnyy @AndrienkoAleksandr @che-bot