Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openshift plugin] fix 'Log in' command #13405

Closed
azatsarynnyy opened this issue May 23, 2019 · 7 comments
Closed

[openshift plugin] fix 'Log in' command #13405

azatsarynnyy opened this issue May 23, 2019 · 7 comments
Assignees
@azatsarynnyy
Labels
kind/bug Outline of a bug - must adhere to the bug report template. kind/task Internal things, technical debt, and to-do tasks to be performed.
Milestone
7.1.0

Comments

@azatsarynnyy
Copy link
Member

azatsarynnyy commented May 23, 2019 •
edited
Loading

OpenShift Connector Che Plugin provides OpenShift: Log in to cluster command that stopped working in v0.0.21.

Diagnostics
The error is reported in a notification:
Cannot read property 'readText' of undefined

Should be fixed by eclipse-theia/theia#5519
@azatsarynnyy azatsarynnyy added kind/task Internal things, technical debt, and to-do tasks to be performed. team/ide labels May 23, 2019
@azatsarynnyy azatsarynnyy self-assigned this May 23, 2019
@AndrienkoAleksandr AndrienkoAleksandr added kind/bug Outline of a bug - must adhere to the bug report template. status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 2, 2019
@AndrienkoAleksandr
Copy link
Contributor

Still reproducible.
Agly workaround:
open new terminal for openshift connector container and login with help oc tool.

@AndrienkoAleksandr AndrienkoAleksandr mentioned this issue Aug 5, 2019
Closed
23 tasks
@benoitf benoitf removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 5, 2019
@benoitf benoitf added this to the 7.1.0 milestone Aug 5, 2019
@AndrienkoAleksandr
Copy link
Contributor

Looks like a bug plugin api.

@vparfonov vparfonov mentioned this issue Aug 7, 2019
Closed
11 tasks
@azatsarynnyy
Copy link
Member Author

VS Code OpenShift Connector extension relies on VS Code extension Clipboard API which isn't implemented in Theia yet.

@azatsarynnyy
Copy link
Member Author

There's PR eclipse-theia/theia#5527 in Theia opened 2 months ago which fixes two issues including adding Clipboard API support.
I've tested the OpenShift plugin with the patch proposed in that PR and Log in command works well.
I'm going to extract the Clipboard API related code to a separate PR.

@azatsarynnyy
Copy link
Member Author

azatsarynnyy commented Aug 22, 2019 •
edited
Loading

should be fixed by eclipse-theia/theia#5994

@vparfonov vparfonov mentioned this issue Sep 3, 2019
Closed
19 tasks
@azatsarynnyy
Copy link
Member Author

Looks like the Log in command works on secure (https) connections only. That prevents using it in Che running on minishift on insecure connection (http).

Log in command utilizes Theia Plugin Clipboard API that relies on browser's Async Clipboard API which works on secure connections only.

Reopening it to investigate the possible solution.

@azatsarynnyy azatsarynnyy reopened this Sep 20, 2019
@azatsarynnyy azatsarynnyy mentioned this issue Sep 20, 2019
Closed
5 tasks
@azatsarynnyy
Copy link
Member Author

For now, I don't see a way how to allow the clipboard access on http.
So 'Log in' command won't work on minishift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azatsarynnyy azatsarynnyy

Labels
kind/bug Outline of a bug - must adhere to the bug report template. kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
7.1.0
Development

No branches or pull requests
3 participants
@benoitf @azatsarynnyy @AndrienkoAleksandr