Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openshift plugin] fix 'Open URL' command #13406

Closed
azatsarynnyy opened this issue May 23, 2019 · 3 comments · Fixed by eclipse-che/che-plugin-registry#283
Closed

[openshift plugin] fix 'Open URL' command #13406

azatsarynnyy opened this issue May 23, 2019 · 3 comments · Fixed by eclipse-che/che-plugin-registry#283
Assignees
@azatsarynnyy
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone
7.4.0

Comments

@azatsarynnyy
Copy link
Member

azatsarynnyy commented May 23, 2019 •
edited
Loading

OpenShift Connector Che Plugin provides Open URL command to open the specific URL in browser.

image

When calling the command by clicking on the icon nothing is happening.
@azatsarynnyy azatsarynnyy added kind/task Internal things, technical debt, and to-do tasks to be performed. team/ide labels May 23, 2019
@azatsarynnyy azatsarynnyy self-assigned this May 23, 2019
@azatsarynnyy azatsarynnyy changed the title [openshift plugin] fix 'Open in Browser' command [openshift plugin] fix 'Open URL' command May 23, 2019
@vparfonov vparfonov mentioned this issue Aug 20, 2019
Closed
19 tasks
@l0rd l0rd added kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system. and removed kind/task Internal things, technical debt, and to-do tasks to be performed. labels Aug 29, 2019
This was referenced Sep 20, 2019
Closed
Closed
@vparfonov vparfonov added this to the 7.3.0 milestone Oct 2, 2019
@vparfonov vparfonov mentioned this issue Oct 11, 2019
Closed
17 tasks
@vparfonov vparfonov modified the milestones: 7.3.0, Backlog - IDE 1 Oct 11, 2019
@vparfonov vparfonov modified the milestones: Backlog - IDE 1, 7.4.0 Oct 23, 2019
@azatsarynnyy
Copy link
Member Author

OpenShift Connector extension relies on 3'rd party library open for opening the URLs. Since Che runs the extension code in a sidecar, calling this lib does nothing on nodejs.

I'm going to provide a PR to the extension upstream to replace open lib with vscode.env.openExternal API which is already implemented in Theia.

@azatsarynnyy
Copy link
Member Author

The upstream issue redhat-developer/vscode-openshift-tools#1249

@vparfonov vparfonov mentioned this issue Oct 31, 2019
Closed
19 tasks
This was referenced Nov 1, 2019
Merged
Merged
@azatsarynnyy
Copy link
Member Author

waiting for eclipse-che/che-plugin-registry#283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azatsarynnyy azatsarynnyy

Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
7.4.0
Development

Successfully merging a pull request may close this issue.

Add OpenShift Connector Che Plugin v0.1.1 eclipse-che/che-plugin-registry
3 participants
@l0rd @azatsarynnyy @vparfonov