Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSH key generation should happen workspace side #13522

Closed
vparfonov opened this issue Jun 12, 2019 · 3 comments
Closed

SSH key generation should happen workspace side #13522

vparfonov opened this issue Jun 12, 2019 · 3 comments
Assignees
@vinokurig
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed.
Milestone
7.x (Later, Futur...

Comments

@vparfonov
Copy link
Contributor

vparfonov commented Jun 12, 2019 •
edited
Loading

Description

At the moment Theia SSH Plugin depends on ws-master. Need to get rid this dependency instead use native ssh-keygen tool for key generation and store directly in preferences in case upload existed key.

Part of #13494
@l0rd l0rd mentioned this issue Jun 12, 2019
Closed
13 tasks
@vparfonov vparfonov mentioned this issue Jun 12, 2019
Closed
14 tasks
@vinokurig vinokurig changed the title Get rid of dependencies SSH Theia Plugin on ws-agent Get rid of dependencies SSH Theia Plugin on ws-master Jul 18, 2019
@vinokurig vinokurig reopened this Jul 18, 2019
@vinokurig vinokurig mentioned this issue Jul 18, 2019
Merged
@vinokurig vinokurig added kind/task Internal things, technical debt, and to-do tasks to be performed. area/editor/theia Issues related to the che-theia IDE of Che and removed target/che7GA labels Jul 18, 2019
@vinokurig
Copy link
Contributor

We need to persist keys to the database to be able to restore them on workspace start, so we need to keep the ssh service in the ws-master.

@vinokurig
Copy link
Contributor

Is it really important to generate key on che-theia side rather than ws-master, if we steel need to store the keys in the ws-master db?

@sunix
Copy link
Contributor

sunix commented Jul 23, 2019

generation and storage are 2 different things right ?
It doesn't make sense to have ssh key generation logic in ws-master.

@l0rd l0rd changed the title Get rid of dependencies SSH Theia Plugin on ws-master SSH key generation should happen Theia side, not ws-master side Jul 23, 2019
@l0rd l0rd changed the title SSH key generation should happen Theia side, not ws-master side SSH key generation should happen workspace side Jul 23, 2019
@l0rd l0rd added this to the 7.x milestone Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinokurig vinokurig

Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
7.x (Later, Future, Never)
Development

No branches or pull requests
4 participants
@l0rd @sunix @vparfonov @vinokurig