-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some Projects don't work with Java 11 based Java plugin #13547
Comments
the issue is reproducible via devfile for spring-rest-guide - https://github.com/ibuziuk/my-che-devfiles/tree/master/spring-rest-guide#the-gradle-version-used-in-that-project-does-not-work-on-java-11 One of the ideas was to exclude gradle via |
The gs-rest-service sample project sort of works with the Che 7 RC1 Gradle 5.2.1 / JDK 11 stack image: https://user-images.githubusercontent.com/227597/59536122-d894b480-8ec0-11e9-9e98-078c0c03a39d.png However, the lang server (?) or something under the covers is still trying to download gradle 4.6: And the console-java-simple project is also confused about JDK 11 (as seen above), but it does work: |
Signed-off-by: nickboldt <nboldt@redhat.com>
…ple projects associated with che7-preview and java-maven stacks will have working preview URLs Signed-off-by: nickboldt <nboldt@redhat.com>
…mple projects associated with che7-preview and java-maven stacks will have working preview URLs Change-Id: I9e1afc3ad423c84b6e2e2fb8190f244051d4a6af Signed-off-by: nickboldt <nboldt@redhat.com>
@nickboldt this is really about the fact that the Java language support plugin is not working. |
Will Java lang support work in time for CRW 2.0? Because if not, I'd suggest reverting whatever you changed to "support" JDK 11. Let's go back to JDK 8, where things worked. :D I mean, I may not be the target audience for Che and CRW, but I think Java 8 support is still pretty important for enterprise. WDYT @slemeur ? This feels like a P1/SEV1/blocker for CRW 2.0 to me. |
Signed-off-by: nickboldt <nboldt@redhat.com>
Ok, after some discussion we're going with a Che plugin per Java version. However, there are a couple of open questions:
|
now alpine is supported by openjdk project https://hub.docker.com/_/openjdk 13-alpine (but this is for the future) |
Can we consider this issue closed since eclipse-che/che-plugin-registry#181 has been merged? |
Yes we can! |
We've recently updated the Che Java tooling to Java 11. It seems of our featured examples do not work with this: https://github.com/spring-guides/gs-rest-service
The project contains setup for both maven and gradle. In this case, jdt.ls sets the project up as a gradle project. However, the project uses gradle 4.6. jdt.ls picks up that tooling, but that craps out because gradle 4.6 does not support running on Java 11.
Need to have a discussion on what the best way forward is.
The text was updated successfully, but these errors were encountered: